Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 12217132: Revert 181898 (Closed)

Created:
7 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 10 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Revert 181898 apparently not at fault > Revert 181812 > > Speculative revert to see whether this broke browser_tests on Win Aura Tests(2) > > A DCHECK() about invalid strings is hit > > > Add a set passphrase dialog which allows to set a passphrase for a managed user account. In a later changelist this will be used for authentication in order to change settings of the account. > > This changelist is extracted from the changelist here: https://codereview.chromium.org/11783008/ in order to break it up. > > A screenshot of the set passphrase page is available here: > > https://docs.google.com/a/google.com/drawings/d/1qXtLoSN2C8Z_qrnNB8yHlJHG96NqL79ciMGaW3amWkw/edit?usp=sharing > > > > BUG=171370 > > TEST=browser_tests, unit_tests > > > > Review URL: https://chromiumcodereview.appspot.com/12208068 > > TBR=akuegel@chromium.org > Review URL: https://codereview.chromium.org/12210136 TBR=jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181905

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -2 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +19 lines, -1 line 0 comments Download
M chrome/browser/managed_mode/managed_user_service.cc View 1 chunk +6 lines, -0 lines 0 comments Download
A + chrome/browser/resources/options/managed_user_set_passphrase.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/options/managed_user_set_passphrase.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/options/managed_user_set_passphrase.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/resources/options/managed_user_settings.js View 3 chunks +10 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/options.html View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/options.js View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/resources/options/options_bundle.js View 1 chunk +1 line, -0 lines 0 comments Download
A + chrome/browser/ui/webui/options/managed_user_passphrase_handler.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/ui/webui/options/managed_user_passphrase_handler.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/ui/webui/options/managed_user_set_passphrase_browsertest.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/ui/webui/options/managed_user_set_passphrase_test.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/ui/webui/options/managed_user_set_passphrase_test.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/ui/webui/options/options_ui.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/pref_names.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/common/pref_names.cc View 3 chunks +12 lines, -5 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jochen (gone - plz use gerrit)
7 years, 10 months ago (2013-02-12 10:44:33 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698