Fix code flusher disabling while marking incrementally.

Fix code flusher disabling while marking incrementally.

This fixes a corner case where the code flusher is disabled while the
incremental marker is still running. This can happen when the debugger
is loaded and a scavenge is triggered. Make sure that all flushing
decisions are revisited after the candidates lists are evicted.

R=hpayer@chromium.org
BUG=chromium:173458, chromium:168582
TEST=cctest/test-heap/Regress173458

Committed: http://code.google.com/p/v8/source/detail?r=13641

[Hannes Payer (out of office), 2013-02-11 14:21:34]

LGTM! A regression test would be nice.

[Michael Starzinger, 2013-02-11 14:47:11]

Done. Uploaded a regression test.

[Hannes Payer (out of office), 2013-02-11 14:48:58]

https://codereview.chromium.org/12217108/diff/4001/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):

https://codereview.chromium.org/12217108/diff/4001/test/cctest/test-heap.cc#n...
test/cctest/test-heap.cc:2877: }
In the future, we may wanna have that code in a function SimulateCodeFlushing().

[Michael Starzinger, 2013-02-11 15:01:33]

https://codereview.chromium.org/12217108/diff/4001/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):

https://codereview.chromium.org/12217108/diff/4001/test/cctest/test-heap.cc#n...
test/cctest/test-heap.cc:2877: }
On 2013/02/11 14:48:58, Hannes Payer wrote:
> In the future, we may wanna have that code in a function
SimulateCodeFlushing().

Agreed, I'll clean that up in a follow-up CL. But let's not do it in this one,
because we want to be able to merge this one back to the branches easily.