test/cctest/test-api.cc - Issue 12217106: Don't use TLS for space iterators.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-api.cc

Issue 12217106: Don't use TLS for space iterators. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed feedback. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-api.cc

diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc

index 64a003e049506ef8f54245fe83f72510ff04be89..a12c560a429cdb4b8dd17807d1a72c0523d01e91 100644

--- a/test/cctest/test-api.cc

+++ b/test/cctest/test-api.cc

@@ -11283,7 +11283,7 @@ THREADED_TEST(LockUnlockLock) {

static int GetGlobalObjectsCount() {

i::Isolate::Current()->heap()->EnsureHeapIsIterable();

int count = 0;

- i::HeapIterator it;

+ i::HeapIterator it(HEAP);

for (i::HeapObject* object = it.next(); object != NULL; object = it.next())

if (object->IsJSGlobalObject()) count++;

return count;

« no previous file with comments | « src/runtime.cc ('k') | test/cctest/test-debug.cc » ('j') | no next file with comments »