Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Unified Diff: src/profile-generator.h

Issue 12217106: Don't use TLS for space iterators. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed feedback. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/mark-compact.cc ('k') | src/profile-generator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/profile-generator.h
diff --git a/src/profile-generator.h b/src/profile-generator.h
index 086e5c650749589e3f2b74ec0cc8f6eb242c2b03..43c737ea19a5e58c2dae8bcb606451aefcef417a 100644
--- a/src/profile-generator.h
+++ b/src/profile-generator.h
@@ -640,7 +640,9 @@ class HeapSnapshot {
class HeapObjectsMap {
public:
- HeapObjectsMap();
+ explicit HeapObjectsMap(Heap* heap);
+
+ Heap* heap() const { return heap_; }
void SnapshotGenerationFinished();
SnapshotObjectId FindEntry(Address addr);
@@ -699,6 +701,7 @@ class HeapObjectsMap {
HashMap entries_map_;
List<EntryInfo> entries_;
List<TimeInterval> time_intervals_;
+ Heap* heap_;
DISALLOW_COPY_AND_ASSIGN(HeapObjectsMap);
};
@@ -706,9 +709,11 @@ class HeapObjectsMap {
class HeapSnapshotsCollection {
public:
- HeapSnapshotsCollection();
+ explicit HeapSnapshotsCollection(Heap* heap);
~HeapSnapshotsCollection();
+ Heap* heap() const { return ids_.heap(); }
+
bool is_tracking_objects() { return is_tracking_objects_; }
SnapshotObjectId PushHeapObjectsStats(OutputStream* stream) {
return ids_.PushHeapObjectsStats(stream);
@@ -1025,7 +1030,8 @@ class HeapSnapshotGenerator : public SnapshottingProgressReportingInterface {
public:
HeapSnapshotGenerator(HeapSnapshot* snapshot,
v8::ActivityControl* control,
- v8::HeapProfiler::ObjectNameResolver* resolver);
+ v8::HeapProfiler::ObjectNameResolver* resolver,
+ Heap* heap);
bool GenerateSnapshot();
private:
@@ -1043,6 +1049,7 @@ class HeapSnapshotGenerator : public SnapshottingProgressReportingInterface {
// Used during snapshot generation.
int progress_counter_;
int progress_total_;
+ Heap* heap_;
DISALLOW_COPY_AND_ASSIGN(HeapSnapshotGenerator);
};
« no previous file with comments | « src/mark-compact.cc ('k') | src/profile-generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698