Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Side by Side Diff: test/cctest/test-debug.cc

Issue 12217106: Don't use TLS for space iterators. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed feedback. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « test/cctest/test-api.cc ('k') | test/cctest/test-heap.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 408 matching lines...) Expand 10 before | Expand all | Expand 10 after
419 // Check that the debugger context is cleared and that there is no debug 419 // Check that the debugger context is cleared and that there is no debug
420 // information stored for the debugger. 420 // information stored for the debugger.
421 CHECK(Isolate::Current()->debug()->debug_context().is_null()); 421 CHECK(Isolate::Current()->debug()->debug_context().is_null());
422 CHECK_EQ(NULL, Isolate::Current()->debug()->debug_info_list_); 422 CHECK_EQ(NULL, Isolate::Current()->debug()->debug_info_list_);
423 423
424 // Collect garbage to ensure weak handles are cleared. 424 // Collect garbage to ensure weak handles are cleared.
425 HEAP->CollectAllGarbage(Heap::kNoGCFlags); 425 HEAP->CollectAllGarbage(Heap::kNoGCFlags);
426 HEAP->CollectAllGarbage(Heap::kMakeHeapIterableMask); 426 HEAP->CollectAllGarbage(Heap::kMakeHeapIterableMask);
427 427
428 // Iterate the head and check that there are no debugger related objects left. 428 // Iterate the head and check that there are no debugger related objects left.
429 HeapIterator iterator; 429 HeapIterator iterator(HEAP);
430 for (HeapObject* obj = iterator.next(); obj != NULL; obj = iterator.next()) { 430 for (HeapObject* obj = iterator.next(); obj != NULL; obj = iterator.next()) {
431 CHECK(!obj->IsDebugInfo()); 431 CHECK(!obj->IsDebugInfo());
432 CHECK(!obj->IsBreakPointInfo()); 432 CHECK(!obj->IsBreakPointInfo());
433 433
434 // If deep check of functions is requested check that no debug break code 434 // If deep check of functions is requested check that no debug break code
435 // is left in all functions. 435 // is left in all functions.
436 if (check_functions) { 436 if (check_functions) {
437 if (obj->IsJSFunction()) { 437 if (obj->IsJSFunction()) {
438 JSFunction* fun = JSFunction::cast(obj); 438 JSFunction* fun = JSFunction::cast(obj);
439 for (RelocIterator it(fun->shared()->code()); !it.done(); it.next()) { 439 for (RelocIterator it(fun->shared()->code()); !it.done(); it.next()) {
(...skipping 7083 matching lines...) Expand 10 before | Expand all | Expand 10 after
7523 TEST(LiveEditDisabled) { 7523 TEST(LiveEditDisabled) {
7524 v8::internal::FLAG_allow_natives_syntax = true; 7524 v8::internal::FLAG_allow_natives_syntax = true;
7525 v8::HandleScope scope; 7525 v8::HandleScope scope;
7526 LocalContext context; 7526 LocalContext context;
7527 v8::Debug::SetLiveEditEnabled(false); 7527 v8::Debug::SetLiveEditEnabled(false);
7528 CompileRun("%LiveEditCompareStrings('', '')"); 7528 CompileRun("%LiveEditCompareStrings('', '')");
7529 } 7529 }
7530 7530
7531 7531
7532 #endif // ENABLE_DEBUGGER_SUPPORT 7532 #endif // ENABLE_DEBUGGER_SUPPORT
OLDNEW
« no previous file with comments | « test/cctest/test-api.cc ('k') | test/cctest/test-heap.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698