cc: Check for completed raster tasks at interval.

cc/raster_worker_pool.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/raster_worker_pool.h"
 
 #include "cc/picture_pile_impl.h"
 
 namespace cc {
 
 namespace {
 
 class RasterWorkerPoolTaskImpl : public internal::WorkerPoolTask {
  public:
   RasterWorkerPoolTaskImpl(PicturePileImpl* picture_pile,
                            const RasterWorkerPool::RasterCallback& task,
                            const base::Closure& reply)
       : internal::WorkerPoolTask(reply),
         picture_pile_(picture_pile),
         task_(task) {
     DCHECK(picture_pile_);
   }
 
   virtual void Run(RenderingStats* rendering_stats) OVERRIDE {
     task_.Run(picture_pile_.get(), rendering_stats);
+    base::subtle::NoBarrier_Store(&completed_, 1);

[brianderson, 2013/02/12 01:44:31]

I think we need a barrier before setting completed_. Otherwise, compiler/cpu
reordering can mark completed_ before we are are actually done.

[reveman, 2013/02/12 02:29:52]

yea, this should already be fixed in patch set 2.

   }
 
  private:
   scoped_refptr<PicturePileImpl> picture_pile_;
   RasterWorkerPool::RasterCallback task_;
 };
 
 }  // namespace
 
 RasterWorkerPool::RasterWorkerPool(size_t num_threads)
@@ skipping 12 matching lines @@
       picture_pile->GetCloneForDrawingOnThread(worker);
 
   worker->PostTask(
       make_scoped_ptr(new RasterWorkerPoolTaskImpl(
                           picture_pile_clone.get(),
                           task,
                           reply)).PassAs<internal::WorkerPoolTask>());
 }
 
 }  // namespace cc