Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 12217103: Print deoptimization index when printing lithium environment. (Closed)

Created:
7 years, 10 months ago by Vyacheslav Egorov (Google)
Modified:
7 years, 10 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Print deoptimization index when printing lithium environment. Output of --trace-deopt --code-comments does not always allow to reliably match deoptimization to the lithium instruction (and it is actually never accurate on x64 due to one level of indirection). This change allows to reliably figure out which instruction deoptimized just by looking up bailout id in the hydrogen.cfg. R=danno@chromium.org BUG= Committed: http://code.google.com/p/v8/source/detail?r=13639

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/lithium.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Vyacheslav Egorov (Google)
Hi, Can you please take a look? This is a very minimal change on a ...
7 years, 10 months ago (2013-02-10 14:55:50 UTC) #1
danno
7 years, 10 months ago (2013-02-11 14:08:56 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698