Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Unified Diff: net/url_request/url_request_job_factory_impl_unittest.cc

Issue 12217095: Remove unused pieces of URLRequestJobFactory API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_job_factory_impl_unittest.cc
diff --git a/net/url_request/url_request_job_factory_impl_unittest.cc b/net/url_request/url_request_job_factory_impl_unittest.cc
index 232b21ac44c5654751b1ad063dbc0d48113d378c..5f0e16c36e54f1a461c9867ea2d5734d008d1067 100644
--- a/net/url_request/url_request_job_factory_impl_unittest.cc
+++ b/net/url_request/url_request_job_factory_impl_unittest.cc
@@ -57,44 +57,6 @@ class DummyProtocolHandler : public URLRequestJobFactory::ProtocolHandler {
}
};
-class DummyInterceptor : public URLRequestJobFactory::Interceptor {
- public:
- DummyInterceptor()
- : did_intercept_(false),
- handle_all_protocols_(false) {
- }
-
- virtual URLRequestJob* MaybeIntercept(
- URLRequest* request, NetworkDelegate* network_delegate) const OVERRIDE {
- did_intercept_ = true;
- return new MockURLRequestJob(
- request,
- network_delegate,
- URLRequestStatus(URLRequestStatus::FAILED, ERR_FAILED));
- }
-
- virtual URLRequestJob* MaybeInterceptRedirect(
- const GURL& /* location */,
- URLRequest* /* request */,
- NetworkDelegate* network_delegate /* network delegate */) const OVERRIDE {
- return NULL;
- }
-
- virtual URLRequestJob* MaybeInterceptResponse(
- URLRequest* /* request */,
- NetworkDelegate* network_delegate /* network delegate */) const OVERRIDE {
- return NULL;
- }
-
- virtual bool WillHandleProtocol(
- const std::string& /* protocol */) const OVERRIDE {
- return handle_all_protocols_;
- }
-
- mutable bool did_intercept_;
- mutable bool handle_all_protocols_;
-};
-
TEST(URLRequestJobFactoryTest, NoProtocolHandler) {
TestDelegate delegate;
TestURLRequestContext request_context;
@@ -128,91 +90,6 @@ TEST(URLRequestJobFactoryTest, DeleteProtocolHandler) {
job_factory.SetProtocolHandler("foo", NULL);
}
-TEST(URLRequestJobFactoryTest, BasicInterceptor) {
- TestDelegate delegate;
- URLRequestJobFactoryImpl job_factory;
- TestURLRequestContext request_context;
- request_context.set_job_factory(&job_factory);
- job_factory.AddInterceptor(new DummyInterceptor);
- TestURLRequest request(GURL("http://bar"), &delegate, &request_context);
- request.Start();
-
- MessageLoop::current()->Run();
- EXPECT_EQ(URLRequestStatus::FAILED, request.status().status());
- EXPECT_EQ(ERR_FAILED, request.status().error());
-}
-
-TEST(URLRequestJobFactoryTest, InterceptorNeedsValidSchemeStill) {
- TestDelegate delegate;
- URLRequestJobFactoryImpl job_factory;
- TestURLRequestContext request_context;
- request_context.set_job_factory(&job_factory);
- job_factory.AddInterceptor(new DummyInterceptor);
- TestURLRequest request(GURL("foo://bar"), &delegate, &request_context);
- request.Start();
-
- MessageLoop::current()->Run();
- EXPECT_EQ(URLRequestStatus::FAILED, request.status().status());
- EXPECT_EQ(ERR_UNKNOWN_URL_SCHEME, request.status().error());
-}
-
-TEST(URLRequestJobFactoryTest, InterceptorOverridesProtocolHandler) {
- TestDelegate delegate;
- URLRequestJobFactoryImpl job_factory;
- TestURLRequestContext request_context;
- request_context.set_job_factory(&job_factory);
- job_factory.SetProtocolHandler("foo", new DummyProtocolHandler);
- job_factory.AddInterceptor(new DummyInterceptor);
- TestURLRequest request(GURL("foo://bar"), &delegate, &request_context);
- request.Start();
-
- MessageLoop::current()->Run();
- EXPECT_EQ(URLRequestStatus::FAILED, request.status().status());
- EXPECT_EQ(ERR_FAILED, request.status().error());
-}
-
-TEST(URLRequestJobFactoryTest, InterceptorDoesntInterceptUnknownProtocols) {
- TestDelegate delegate;
- URLRequestJobFactoryImpl job_factory;
- TestURLRequestContext request_context;
- request_context.set_job_factory(&job_factory);
- DummyInterceptor* interceptor = new DummyInterceptor;
- job_factory.AddInterceptor(interceptor);
- TestURLRequest request(GURL("foo://bar"), &delegate, &request_context);
- request.Start();
-
- MessageLoop::current()->Run();
- EXPECT_FALSE(interceptor->did_intercept_);
-}
-
-TEST(URLRequestJobFactoryTest, InterceptorInterceptsHandledUnknownProtocols) {
- TestDelegate delegate;
- URLRequestJobFactoryImpl job_factory;
- TestURLRequestContext request_context;
- request_context.set_job_factory(&job_factory);
- DummyInterceptor* interceptor = new DummyInterceptor;
- interceptor->handle_all_protocols_ = true;
- job_factory.AddInterceptor(interceptor);
- TestURLRequest request(GURL("foo://bar"), &delegate, &request_context);
- request.Start();
-
- MessageLoop::current()->Run();
- EXPECT_TRUE(interceptor->did_intercept_);
- EXPECT_EQ(URLRequestStatus::FAILED, request.status().status());
- EXPECT_EQ(ERR_FAILED, request.status().error());
-}
-
-TEST(URLRequestJobFactoryTest, InterceptorAffectsIsHandledProtocol) {
- DummyInterceptor* interceptor = new DummyInterceptor;
- URLRequestJobFactoryImpl job_factory;
- job_factory.AddInterceptor(interceptor);
- EXPECT_FALSE(interceptor->WillHandleProtocol("anything"));
- EXPECT_FALSE(job_factory.IsHandledProtocol("anything"));
- interceptor->handle_all_protocols_ = true;
- EXPECT_TRUE(interceptor->WillHandleProtocol("anything"));
- EXPECT_TRUE(job_factory.IsHandledProtocol("anything"));
-}
-
} // namespace
} // namespace net

Powered by Google App Engine
This is Rietveld 408576698