Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Unified Diff: android_webview/browser/net/aw_url_request_job_factory.h

Issue 12217095: Remove unused pieces of URLRequestJobFactory API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/net/aw_url_request_job_factory.h
diff --git a/android_webview/browser/net/aw_url_request_job_factory.h b/android_webview/browser/net/aw_url_request_job_factory.h
index 3201fbd77dab307791396604f05f8797daf097d4..aa2a3ddc7d121e92bd3ab1ec239e76a0656727d8 100644
--- a/android_webview/browser/net/aw_url_request_job_factory.h
+++ b/android_webview/browser/net/aw_url_request_job_factory.h
@@ -8,6 +8,10 @@
#include "base/memory/scoped_ptr.h"
#include "net/url_request/url_request_job_factory.h"
+namespace net {
+class URLRequestJobFactoryImpl;
+} // namespace net
+
namespace android_webview {
// android_webview uses a custom URLRequestJobFactoryImpl to support
@@ -21,30 +25,21 @@ class AwURLRequestJobFactory : public net::URLRequestJobFactory {
AwURLRequestJobFactory();
virtual ~AwURLRequestJobFactory();
- virtual bool SetProtocolHandler(const std::string& scheme,
- ProtocolHandler* protocol_handler) OVERRIDE;
- virtual void AddInterceptor(Interceptor* interceptor) OVERRIDE;
- virtual net::URLRequestJob* MaybeCreateJobWithInterceptor(
- net::URLRequest* request,
- net::NetworkDelegate* network_delegate) const OVERRIDE;
+ bool SetProtocolHandler(const std::string& scheme,
+ ProtocolHandler* protocol_handler);
+
+ // net::URLRequestJobFactory implementation
mmenke 2013/02/11 17:19:32 nit: These typically end in a colon or period.
virtual net::URLRequestJob* MaybeCreateJobWithProtocolHandler(
const std::string& scheme,
net::URLRequest* request,
net::NetworkDelegate* network_delegate) const OVERRIDE;
- virtual net::URLRequestJob* MaybeInterceptRedirect(
- const GURL& location,
- net::URLRequest* request,
- net::NetworkDelegate* network_delegate) const OVERRIDE;
- virtual net::URLRequestJob* MaybeInterceptResponse(
- net::URLRequest* request,
- net::NetworkDelegate* network_delegate) const OVERRIDE;
virtual bool IsHandledProtocol(const std::string& scheme) const OVERRIDE;
virtual bool IsHandledURL(const GURL& url) const OVERRIDE;
private:
// By default calls are forwarded to this factory, to avoid having to
// subclass an existing implementation class.
- scoped_ptr<URLRequestJobFactory> next_factory_;
+ scoped_ptr<net::URLRequestJobFactoryImpl> next_factory_;
DISALLOW_COPY_AND_ASSIGN(AwURLRequestJobFactory);
};

Powered by Google App Engine
This is Rietveld 408576698