tools/dom/scripts/systemhtml.py - Issue 12217089: Allow non-primitive-value dictionaries to be passed to constructors for html

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/scripts/systemhtml.py

Issue 12217089: Allow non-primitive-value dictionaries to be passed to constructors for html (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/dom/scripts/generator.py ('k') | tools/dom/templates/html/dart2js/impl_Notification.darttemplate » ('j') | tools/dom/templates/html/dart2js/impl_Notification.darttemplate » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/dom/scripts/systemhtml.py

diff --git a/tools/dom/scripts/systemhtml.py b/tools/dom/scripts/systemhtml.py

index f960434674d7d21029f23ef0943997db9b670698..bae81fdf8bc0b522e5b726282563d77b8b7dac92 100644

--- a/tools/dom/scripts/systemhtml.py

+++ b/tools/dom/scripts/systemhtml.py

@@ -70,6 +70,17 @@ _js_custom_members = set([

'WorkerContext.indexedDB',

])

+_js_custom_constructors = set([

+ 'AudioContext',

+ 'Blob',

+ 'MutationObserver',

+ 'Notification',

+ 'RTCIceCandidate',

+ 'RTCPeerConnection',

+ 'RTCSessionDescription',

+ 'SpeechRecognition',

+ ])

# Classes that offer only static methods, and therefore we should suppress

# constructor creation.

_static_classes = set(['Url'])

@@ -611,12 +622,7 @@ class Dart2JSBackend(HtmlDartGenerator):

def GenerateCustomFactory(self, constructor_info):

# Custom factory will be taken from the template.

- return self._interface.doc_js_name in [

- 'AudioContext',

- 'Blob',

- 'MutationObserver',

- 'SpeechRecognition',

- ]

+ return self._interface.doc_js_name in _js_custom_constructors

def IsConstructorArgumentOptional(self, argument):

return 'Optional' in argument.ext_attrs