Proxy WebData-based WebIDBDatabase::put

Proxy WebData-based WebIDBDatabase::put

BUG=


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182392

[alecflett, 2013-02-06 21:44:55]

tsepez / jsbell - r?

[Tom Sepez, 2013-02-06 21:48:08]

Rubberstamp LGTM on changing type in message.

[jsbell, 2013-02-07 00:06:07]

lgtm with namespace nits

https://codereview.chromium.org/12217049/diff/1/content/browser/in_process_we...
File content/browser/in_process_webkit/indexed_db_dispatcher_host.cc (right):

https://codereview.chromium.org/12217049/diff/1/content/browser/in_process_we...
content/browser/in_process_webkit/indexed_db_dispatcher_host.cc:504:
WebKit::WebData value(params.value);
In .cc files we typically add a "using" line near the top of the file rather
than namespace prefixes at the point of usage.

https://codereview.chromium.org/12217049/diff/1/content/common/indexed_db/ind...
File content/common/indexed_db/indexed_db_dispatcher.cc (right):

https://codereview.chromium.org/12217049/diff/1/content/common/indexed_db/ind...
content/common/indexed_db/indexed_db_dispatcher.cc:430: const WebKit::WebData&
value,
ditto

https://codereview.chromium.org/12217049/diff/1/content/common/indexed_db/ind...
content/common/indexed_db/indexed_db_dispatcher.cc:432:
WebKit::WebIDBDatabase::PutMode put_mode,
And this webKit:: prefix shouldn't be necessary because there's a "using
WebKit::WebIDBDatabase" declaration

https://codereview.chromium.org/12217049/diff/1/content/common/indexed_db/ind...
content/common/indexed_db/indexed_db_dispatcher.cc:433: WebKit::WebIDBCallbacks*
callbacks,
Or this one, etc.

[commit-bot: I haz the power, 2013-02-07 00:18:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alecflett@chromium.org/12217049/2002

[commit-bot: I haz the power, 2013-02-07 01:30:12]

Failed to trigger a try job on mac
HTTP Error 400: Bad Request

[commit-bot: I haz the power, 2013-02-07 01:30:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alecflett@chromium.org/12217049/5006

[commit-bot: I haz the power, 2013-02-07 03:00:10]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-02-07 04:32:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alecflett@chromium.org/12217049/11007

[commit-bot: I haz the power, 2013-02-07 04:55:48]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-02-07 05:30:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alecflett@chromium.org/12217049/2006

[commit-bot: I haz the power, 2013-02-07 06:02:35]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[alecflett, 2013-02-07 06:52:04]

On 2013/02/07 06:02:35, I haz the power (commit-bot) wrote:
> Sorry for I got bad news for ya.
> Compile failed with a clobber build on android_dbg.
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
> Your code is likely broken or HEAD is junk. Please ensure your
> code is not broken then alert the build sheriffs.
> Look at the try server FAQ for more details.

Ugh I am discovering that WebData(std::vector<char>) is calling
std::vector<char>::data() which is a C++11ism. That's why the android port is
failing.

So now we're looking at creating two copies just to make signatures match up...
std::vector -> WebVector and WebVector -> WebData. Yuck.

[jsbell, 2013-02-07 16:35:21]

On 2013/02/07 06:52:04, alecflett wrote:
> 
> Ugh I am discovering that WebData(std::vector<char>) is calling
> std::vector<char>::data() which is a C++11ism. That's why the android port is
> failing.
> 
> So now we're looking at creating two copies just to make signatures match
up...
> std::vector -> WebVector and WebVector -> WebData. Yuck.

Per http://en.cppreference.com/w/cpp/container/vector/data data() is the same as
&front() which special guarantees for zero-size vectors.

It seems to me that we should remove the C++11ism from WebData - which may have
snuck in accidentally? - and have it use &front() with a special case for
zero-size.

[commit-bot: I haz the power, 2013-02-14 01:03:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alecflett@chromium.org/12217049/11009

[commit-bot: I haz the power, 2013-02-14 01:23:53]

Retried try job too often on linux_aura for step(s) aura_unittests,
browser_tests, compositor_unittests, content_browsertests, content_unittests,
interactive_ui_tests, unit_tests, views_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2013-02-14 01:44:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alecflett@chromium.org/12217049/11009

[commit-bot: I haz the power, 2013-02-14 02:04:36]

Retried try job too often on linux_aura for step(s) aura_unittests,
browser_tests, compositor_unittests, content_browsertests, content_unittests,
interactive_ui_tests, unit_tests, views_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2013-02-14 03:06:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alecflett@chromium.org/12217049/11009

[commit-bot: I haz the power, 2013-02-14 05:14:44]

Change committed as 182392