Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: src/objects-debug.cc

Issue 12217025: For HashTable-backed JS objects, use the proper type in the table() accessor (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects.cc ('k') | src/objects-inl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects-debug.cc
diff --git a/src/objects-debug.cc b/src/objects-debug.cc
index 60463684999001b779eef13970299db1d6a3ed08..0fd9f7dfbab97fe369b3447bec35a5b0ac73d415 100644
--- a/src/objects-debug.cc
+++ b/src/objects-debug.cc
@@ -623,24 +623,32 @@ void JSArray::JSArrayVerify() {
void JSSet::JSSetVerify() {
CHECK(IsJSSet());
JSObjectVerify();
- VerifyHeapPointer(table());
- CHECK(table()->IsHashTable() || table()->IsUndefined());
+ VerifyObjectField(kTableOffset);
+ Object* table = *RawField(this, kTableOffset);
+ CHECK(table->IsHashTable() || table->IsUndefined());
}
void JSMap::JSMapVerify() {
CHECK(IsJSMap());
JSObjectVerify();
- VerifyHeapPointer(table());
- CHECK(table()->IsHashTable() || table()->IsUndefined());
+ VerifyObjectField(kTableOffset);
+ Object* table = *RawField(this, kTableOffset);
+ CHECK(table->IsHashTable() || table->IsUndefined());
}
void JSWeakMap::JSWeakMapVerify() {
CHECK(IsJSWeakMap());
JSObjectVerify();
- VerifyHeapPointer(table());
- CHECK(table()->IsHashTable() || table()->IsUndefined());
+ VerifyObjectField(kTableOffset);
+ VerifyObjectField(kNextOffset);
+ Object* table = *RawField(this, kTableOffset);
+ CHECK(table->IsHashTable() || table->IsUndefined());
+ if (next()->IsSmi())
+ CHECK_EQ(0, Smi::cast(next())->value());
+ else
+ CHECK(next()->IsJSWeakMap() || next()->IsUndefined());
}
« no previous file with comments | « src/objects.cc ('k') | src/objects-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698