Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 12217023: NaCl: Remove use of nacl::DescWrapper from nacl_ipc_adapter.cc (Closed)

Created:
7 years, 10 months ago by Mark Seaborn
Modified:
7 years, 10 months ago
CC:
chromium-reviews, native-client-reviews_googlegroups.com
Visibility:
Public.

Description

NaCl: Remove use of nacl::DescWrapper from nacl_ipc_adapter.cc NaCl's DescWrapper class is deprecated and we don't want Chromium-side code to be using it. The main reason for using it before was the Import*() methods, but we've added C constructors to replace these. So that RewrittenMessage unrefs NaClDescs automatically, we add a new wrapper class. BUG=https://code.google.com/p/nativeclient/issues/detail?id=3278 TEST=NaCl tests in browser_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181290

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add DISALLOW_COPY_AND_ASSIGN #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -14 lines) Patch
M chrome/nacl/nacl_ipc_adapter.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/nacl/nacl_ipc_adapter.cc View 1 6 chunks +24 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Mark Seaborn
7 years, 10 months ago (2013-02-06 02:10:04 UTC) #1
dmichael (off chromium)
lgtm https://codereview.chromium.org/12217023/diff/1/chrome/nacl/nacl_ipc_adapter.cc File chrome/nacl/nacl_ipc_adapter.cc (right): https://codereview.chromium.org/12217023/diff/1/chrome/nacl/nacl_ipc_adapter.cc#newcode105 chrome/nacl/nacl_ipc_adapter.cc:105: }; DISALLOW_COPY_AND_ASSIGN. Even though it's a small, local ...
7 years, 10 months ago (2013-02-06 19:19:26 UTC) #2
Mark Seaborn
https://codereview.chromium.org/12217023/diff/1/chrome/nacl/nacl_ipc_adapter.cc File chrome/nacl/nacl_ipc_adapter.cc (right): https://codereview.chromium.org/12217023/diff/1/chrome/nacl/nacl_ipc_adapter.cc#newcode105 chrome/nacl/nacl_ipc_adapter.cc:105: }; On 2013/02/06 19:19:26, dmichael wrote: > DISALLOW_COPY_AND_ASSIGN. Even ...
7 years, 10 months ago (2013-02-07 06:23:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mseaborn@chromium.org/12217023/4003
7 years, 10 months ago (2013-02-07 06:24:25 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=109398
7 years, 10 months ago (2013-02-07 08:19:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mseaborn@chromium.org/12217023/4003
7 years, 10 months ago (2013-02-07 11:29:04 UTC) #6
commit-bot: I haz the power
7 years, 10 months ago (2013-02-07 13:28:09 UTC) #7
Message was sent while issue was closed.
Change committed as 181290

Powered by Google App Engine
This is Rietveld 408576698