chrome/android/java/res/layout/custom_tabs_toolbar.xml - Issue 1221693002: Fix accessibility issues in custom tab UI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/layout/custom_tabs_toolbar.xml

Issue 1221693002: Fix accessibility issues in custom tab UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: new string Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/android/java/res/layout/custom_tabs_toolbar.xml

diff --git a/chrome/android/java/res/layout/custom_tabs_toolbar.xml b/chrome/android/java/res/layout/custom_tabs_toolbar.xml

index cfca2f88d76f74c53da5317ec63fb40d384721d0..e613d8e960ebb274a09a702fb9ddeae21cf05687 100644

--- a/chrome/android/java/res/layout/custom_tabs_toolbar.xml

+++ b/chrome/android/java/res/layout/custom_tabs_toolbar.xml

@@ -8,7 +8,8 @@

android:id="@+id/back_button"

style="@style/ToolbarButton"

android:layout_gravity="center_vertical"

- android:src="@drawable/btn_chevron_left" />

+ android:src="@drawable/btn_chevron_left"

+ android:contentDescription="@string/accessibility_toolbar_btn_close_webpage" />

<ImageButton android:id="@+id/security_button"

style="@style/LocationBarButton"

android:layout_width="@dimen/location_bar_icon_width"