Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java

Issue 1221693002: Fix accessibility issues in custom tab UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nit Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java
index 39b829925c41e0ed695718b050f7dcfc92cafccd..9d7efbdb3d4be80348f6c615a596ef6bceb42ac8 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java
@@ -38,7 +38,6 @@ import android.view.animation.LinearInterpolator;
import android.widget.FrameLayout;
import android.widget.ImageView;
import android.widget.TextView;
-import android.widget.Toast;
import org.chromium.base.ApiCompatibilityUtils;
import org.chromium.base.SysUtils;
@@ -400,28 +399,13 @@ public class ToolbarPhone extends ToolbarLayout
@Override
public boolean onLongClick(View v) {
- int stringResourceId = -1;
+ int stringResourceId = 0;
if (v == mToggleTabStackButton) {
stringResourceId = R.string.open_tabs;
+ } else {
+ return false;
}
- if (stringResourceId != -1) {
- Context ctx = getContext();
- // Display the tooltip for the view being long clicked.
- final int screenWidth = getResources().getDisplayMetrics().widthPixels;
- final int[] screenPos = new int[2];
- v.getLocationOnScreen(screenPos);
- final int width = v.getWidth();
-
- Toast toast = Toast.makeText(
- ctx, getResources().getString(stringResourceId), Toast.LENGTH_SHORT);
- toast.setGravity(
- Gravity.TOP | Gravity.END,
- screenWidth - screenPos[0] - width / 2,
- getHeight());
- toast.show();
- return true;
- }
- return false;
+ return showAccessibilityToast(v, stringResourceId);
}
@Override
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698