Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 1221683006: [turbofan] Remove unused constructor function matching from typer. (Closed)

Created:
5 years, 5 months ago by Benedikt Meurer
Modified:
5 years, 5 months ago
Reviewers:
Jarin
CC:
v8-dev, rossberg
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove unused constructor function matching from typer. This optimization never triggers currently, and is inherently native context dependent for no real reason (for example it will not properly detect those constructors in the case of cross native context inlining), plus it is slow and awkward. In case we really need this functionality at some point, we should find a way to make it work with the builtin function id mechanism that is already in place to match other builtins. R=jarin@chromium.org,rossberg@chromium.org Committed: https://crrev.com/722e2e2b36d9add4b63cc70b108b735a28192354 Cr-Commit-Position: refs/heads/master@{#29365}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -45 lines) Patch
M src/compiler/pipeline.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/typer.h View 3 chunks +2 lines, -4 lines 0 comments Download
M src/compiler/typer.cc View 5 chunks +2 lines, -31 lines 0 comments Download
M test/cctest/compiler/test-changes-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-js-constant-cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-machine-operator-reducer.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/unittests/compiler/graph-unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 5 months ago (2015-06-30 03:47:03 UTC) #1
Benedikt Meurer
Hey Jaro, This code is awkward and inherently native context dependent, plus we don't need ...
5 years, 5 months ago (2015-06-30 03:50:31 UTC) #2
Jarin
lgtm
5 years, 5 months ago (2015-06-30 07:33:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1221683006/1
5 years, 5 months ago (2015-06-30 07:33:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-06-30 07:36:20 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-06-30 07:36:35 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/722e2e2b36d9add4b63cc70b108b735a28192354
Cr-Commit-Position: refs/heads/master@{#29365}

Powered by Google App Engine
This is Rietveld 408576698