Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc

Issue 1221663009: Expose API to store and load data usage stats from UI task runner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Breakdown
Patch Set: Add DCHECK Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc
index 1052ff66316203c3ecea0b5ab0b361da90ee5892..cfeeb022aaac61a4b35c9077b80ac0f2f43e8c22 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc
@@ -4,6 +4,7 @@
#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.h"
+#include <string>
#include <vector>
#include "base/basictypes.h"
@@ -367,15 +368,18 @@ class DailyDataSavingUpdate {
} // namespace
DataReductionProxyCompressionStats::DataReductionProxyCompressionStats(
+ DataReductionProxyService* service,
PrefService* prefs,
- scoped_refptr<base::SequencedTaskRunner> task_runner,
- const base::TimeDelta& delay)
- : pref_service_(prefs),
+ const scoped_refptr<base::SequencedTaskRunner>& task_runner,
+ base::TimeDelta delay)
+ : service_(service),
+ pref_service_(prefs),
task_runner_(task_runner),
delay_(delay),
delayed_task_posted_(false),
pref_change_registrar_(new PrefChangeRegistrar()),
weak_factory_(this) {
+ DCHECK(service);
DCHECK(prefs);
DCHECK_GE(delay.InMilliseconds(), 0);
Init();
@@ -385,7 +389,6 @@ DataReductionProxyCompressionStats::~DataReductionProxyCompressionStats() {
DCHECK(thread_checker_.CalledOnValidThread());
WritePrefs();
pref_change_registrar_->RemoveAll();
- weak_factory_.InvalidateWeakPtrs();
}
void DataReductionProxyCompressionStats::Init() {
@@ -450,6 +453,8 @@ void DataReductionProxyCompressionStats::UpdateContentLengths(
SetInt64(data_reduction_proxy::prefs::kHttpOriginalContentLength,
total_original);
+ // TODO(kundaji): Collect data usage metrics broken down by site and store
+ // in |data_usage_store_|.
RecordContentLengthPrefs(received_content_length, original_content_length,
data_reduction_proxy_enabled, request_type,
mime_type, base::Time::Now());

Powered by Google App Engine
This is Rietveld 408576698