Expose API to store and load data usage stats from UI task runner.

chrome/browser/renderer_context_menu/render_view_context_menu_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/renderer_context_menu/render_view_context_menu.h"
 
 #include "base/prefs/pref_registry_simple.h"
 #include "base/prefs/pref_service.h"
 #include "base/run_loop.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/thread_task_runner_handle.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/custom_handlers/protocol_handler_registry.h"
 #include "chrome/browser/extensions/menu_manager.h"
 #include "chrome/browser/extensions/menu_manager_factory.h"
 #include "chrome/browser/extensions/test_extension_environment.h"
 #include "chrome/browser/extensions/test_extension_prefs.h"
 #include "chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h"
 #include "chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings_factory.h"
 #include "chrome/browser/prefs/incognito_mode_prefs.h"
 #include "chrome/browser/renderer_context_menu/render_view_context_menu_test_util.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/test/base/chrome_render_view_host_test_harness.h"
 #include "chrome/test/base/testing_profile.h"
 #include "components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.h"
+#include "components/data_reduction_proxy/core/browser/data_store.h"
 #include "components/data_reduction_proxy/core/common/data_reduction_proxy_headers.h"
 #include "components/data_reduction_proxy/core/common/data_reduction_proxy_params.h"
 #include "components/data_reduction_proxy/core/common/data_reduction_proxy_pref_names.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/test/web_contents_tester.h"
 
 #include "extensions/browser/extension_prefs.h"
 #include "extensions/common/url_pattern.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/WebKit/public/web/WebContextMenuData.h"
@@ skipping 347 matching lines @@
     registry->RegisterDictionaryPref(prefs::kProxy);
 
     drp_test_context_->pref_service()->SetBoolean(
         data_reduction_proxy::prefs::kDataReductionProxyEnabled,
         enable_data_reduction_proxy);
     drp_test_context_->InitSettings();
 
     settings->InitDataReductionProxySettings(
         drp_test_context_->io_data(), drp_test_context_->pref_service(),
         drp_test_context_->request_context_getter(),
+        make_scoped_ptr(new data_reduction_proxy::DataStore()).Pass(),
+        base::ThreadTaskRunnerHandle::Get(),
         base::ThreadTaskRunnerHandle::Get());

[jeremyim, 2015/07/13 20:19:40]

It would be nice (but not necessary) if more of the boilerplate could be removed
(possibly by having drp_test_context_ expose a method to initialize an external
settings object).

[Not at Google. Contact bengr, 2015/07/14 16:41:30]

It seems confusing to have 2 settings objects, so I am hesitant to put code in
drp_test_context_ that encourages this.

Also, the DRPChromeSettings::InitDRPSettings is only called from this test, so
doesn't get us any reduction in total code lines.

Ideally, the builder would take an external DRPChromeSettings object.

[jeremyim, 2015/07/14 22:39:54]

I'm not looking for reduction in total code lines; I'm looking for a way that
changes in the way DRP classes are hooked up don't bleed into test code
(especially outside of the DRP component) and require updates elsewhere.

Having the builder take an external DRPChromeSettings seems like a great idea;
it might have solved the previous issues you had trying to get the test to work.
=)

[Not at Google. Contact bengr, 2015/07/15 00:08:17]

Sounds good. I'll do this in a separate cl.

[Not at Google. Contact bengr, 2015/07/15 22:34:09]

Jeremy: I investigated this further. Moving initialization of DRPChromeSettings
to DRPTestContext will add a dependency (in DRPTestContext) on the following
files:
       
'../chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc',
       
'../chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h',
        '../chrome/common/pref_names.cc',
        '../chrome/common/pref_names.h',
        '../chrome/browser/browser_process.cc',
        '../chrome/browser/browser_process.h',
        '../chrome/browser/metrics/chrome_metrics_service_accessor.cc',
        '../chrome/browser/metrics/chrome_metrics_service_accessor.h',
        '../chrome/browser/profiles/profile.cc',
        '../chrome/browser/profiles/profile.h',
        '../chrome/browser/profiles/profile_manager.cc',
        '../chrome/browser/profiles/profile_manager.h',
        '../chrome/common/pref_names.cc',
        '../chrome/common/pref_names.h',
With this in mind, I don't think this is a good idea. What do you think?

   }
 
  protected:
   scoped_ptr<data_reduction_proxy::DataReductionProxyTestContext>
       drp_test_context_;
 
  private:
   scoped_ptr<ProtocolHandlerRegistry> registry_;
 };
 
@@ skipping 74 matching lines @@
   params.properties[data_reduction_proxy::chrome_proxy_header()] =
       data_reduction_proxy::chrome_proxy_lo_fi_directive();
   params.unfiltered_link_url = params.link_url;
   content::WebContents* wc = web_contents();
   scoped_ptr<TestRenderViewContextMenu> menu(
       new TestRenderViewContextMenu(wc->GetMainFrame(), params));
   AppendImageItems(menu.get());
 
   ASSERT_TRUE(menu->IsItemPresent(IDC_CONTENT_CONTEXT_LOAD_ORIGINAL_IMAGE));
 }