config services: services.cfg and validation

appengine/config_service/gitiles_import.py

 # Copyright 2015 The Swarming Authors. All rights reserved.
 # Use of this source code is governed by the Apache v2.0 license that can be
 # found in the LICENSE file.
 
 """Imports config files stored in Gitiles.
 
 If services_config_location is set in admin.GlobalConfig root entity,
 each directory in the location is imported as services/<directory_name>.
 
 For each project defined in the project registry with
@@ skipping 160 matching lines @@
     logging.error(
         'Could not import config set %s from %s: urlfetch deadline exceeded',
         config_set, location)
   except net.AuthError:
     logging.error(
         'Could not import config set %s from %s: permission denied',
         config_set, location)
 
 
 def import_services(location_root):
+  # TODO(nodir): import services from location specified in services.cfg
   assert location_root
   tree = location_root.get_tree()
 
   for service_entry in tree.entries:
     service_id = service_entry.name
     if service_entry.type != 'tree':
       continue
     if not config.validation.is_valid_service_id(service_id):
       logging.error('Invalid service id: %s', service_id)
       continue
@@ skipping 57 matching lines @@
 
 
 def cron_run_import():  # pragma: no cover
   conf = admin.GlobalConfig.fetch()
   gitiles_type = admin.ServiceConfigStorageType.GITILES
   if (conf and conf.services_config_storage_type == gitiles_type and
       conf.services_config_location):
     loc = gitiles.Location.parse_resolve(conf.services_config_location)
     import_services(loc)
   import_projects()