Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 1221643016: Fix some clang warnings with -Wmissing-braces in printing. (Closed)

Created:
5 years, 5 months ago by dcheng
Modified:
5 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix some clang warnings with -Wmissing-braces in printing. Clang warns if there are missing braces around a subobject initializer. The most common idiom that triggers this is: STRUCT s = {0}; if the first field of STRUCT is itself a struct. This can be more simply written as: STRUCT s = {}; which also prevents the warning from firing. BUG=505297 Committed: https://crrev.com/475b2e8fdde79348aaef7ffab71a283f4171a733 Cr-Commit-Position: refs/heads/master@{#337086}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M printing/backend/win_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
5 years, 5 months ago (2015-07-01 18:32:28 UTC) #2
Vitaly Buka (NO REVIEWS)
lgtm
5 years, 5 months ago (2015-07-01 18:41:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1221643016/1
5 years, 5 months ago (2015-07-01 18:42:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-01 19:17:08 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-01 19:18:04 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/475b2e8fdde79348aaef7ffab71a283f4171a733
Cr-Commit-Position: refs/heads/master@{#337086}

Powered by Google App Engine
This is Rietveld 408576698