content/browser/service_worker/service_worker_version_unittest.cc - Issue 1221643014: Service Worker: Migrate to version_uuid and surface ServiceWorker.id. (Chromium 2/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_version_unittest.cc

Issue 1221643014: Service Worker: Migrate to version_uuid and surface ServiceWorker.id. (Chromium 2/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_version.cc ('k') | content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_version_unittest.cc

diff --git a/content/browser/service_worker/service_worker_version_unittest.cc b/content/browser/service_worker/service_worker_version_unittest.cc

index 58a5fb522f47a96a7e51cc04e852e43238344a63..aea9a1b1cad06e04b0554a5aacf7c227bf929287 100644

--- a/content/browser/service_worker/service_worker_version_unittest.cc

+++ b/content/browser/service_worker/service_worker_version_unittest.cc

@@ -157,9 +157,8 @@ class ServiceWorkerVersionTest : public testing::Test {

1L,

helper_->context()->AsWeakPtr());

version_ = new ServiceWorkerVersion(

- registration_.get(),

- GURL("http://www.example.com/service_worker.js"),

- 1L,

+ registration_.get(), GURL("http://www.example.com/service_worker.js"),

+ std::string("2d73e817-7136-4133-8d59-84105fe5417a"),

helper_->context()->AsWeakPtr());

std::vector<ServiceWorkerDatabase::ResourceRecord> records;

records.push_back(

@@ -210,7 +209,7 @@ class MessageReceiverDisallowStart : public MessageReceiver {

~MessageReceiverDisallowStart() override {}

void OnStartWorker(int embedded_worker_id,

- int64 service_worker_version_id,

+ std::string service_worker_version_uuid,

const GURL& scope,

const GURL& script_url,

bool pause_after_download) override {