content/browser/service_worker/service_worker_dispatcher_host_unittest.cc - Issue 1221643014: Service Worker: Migrate to version_uuid and surface ServiceWorker.id. (Chromium 2/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_dispatcher_host_unittest.cc

Issue 1221643014: Service Worker: Migrate to version_uuid and surface ServiceWorker.id. (Chromium 2/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_dispatcher_host.cc ('k') | content/browser/service_worker/service_worker_handle.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_dispatcher_host_unittest.cc

diff --git a/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc b/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc

index 462d093bae277e4b025794237f480e329178cbfa..cb44e9c33c2636bbaa1a37d8f0220c423f0f9fe7 100644

--- a/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc

+++ b/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc

@@ -501,11 +501,10 @@ TEST_F(ServiceWorkerDispatcherHostTest, CleanupOnRendererCrash) {

new ServiceWorkerRegistration(pattern,

1L,

helper_->context()->AsWeakPtr()));

- scoped_refptr<ServiceWorkerVersion> version(

- new ServiceWorkerVersion(registration.get(),

- GURL("http://www.example.com/service_worker.js"),

- 1L,

- helper_->context()->AsWeakPtr()));

+ scoped_refptr<ServiceWorkerVersion> version(new ServiceWorkerVersion(

+ registration.get(), GURL("http://www.example.com/service_worker.js"),

+ std::string("2d73e817-7136-4133-8d59-84105fe5417a"),

+ helper_->context()->AsWeakPtr()));

std::vector<ServiceWorkerDatabase::ResourceRecord> records;

records.push_back(

ServiceWorkerDatabase::ResourceRecord(10, version->script_url(), 100));