content/browser/service_worker/service_worker_disk_cache_migrator_unittest.cc - Issue 1221643014: Service Worker: Migrate to version_uuid and surface ServiceWorker.id. (Chromium 2/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_disk_cache_migrator_unittest.cc

Issue 1221643014: Service Worker: Migrate to version_uuid and surface ServiceWorker.id. (Chromium 2/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_database_unittest.cc ('k') | content/browser/service_worker/service_worker_dispatcher_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_disk_cache_migrator_unittest.cc

diff --git a/content/browser/service_worker/service_worker_disk_cache_migrator_unittest.cc b/content/browser/service_worker/service_worker_disk_cache_migrator_unittest.cc

index 6ea4abdc0a10e9d6e999dccef46b0ed13ffb1121..279913c431a3f63df30da04cda77ee61339d114a 100644

--- a/content/browser/service_worker/service_worker_disk_cache_migrator_unittest.cc

+++ b/content/browser/service_worker/service_worker_disk_cache_migrator_unittest.cc

@@ -367,7 +367,7 @@ TEST_F(ServiceWorkerDiskCacheMigratorTest, MigrateOnDiskCacheAccess) {

data.registration_id = 100;

data.scope = GURL("https://example.com/");

data.script = GURL("https://example.com/script.js");

- data.version_id = 200;

+ data.version_uuid = "84a19bb1-148b-484d-a3ff-1ab43ac3fe53";

data.resources_total_size_bytes = 10;

ASSERT_EQ(ServiceWorkerDatabase::STATUS_OK,

database->WriteRegistration(data, resources, &deleted_version,

@@ -437,7 +437,7 @@ TEST_F(ServiceWorkerDiskCacheMigratorTest, NotMigrateOnDatabaseAccess) {

data.registration_id = 100;

data.scope = GURL("https://example.com/");

data.script = GURL("https://example.com/script.js");

- data.version_id = 200;

+ data.version_uuid = "84a19bb1-148b-484d-a3ff-1ab43ac3fe53";

data.resources_total_size_bytes = 10;

ASSERT_EQ(ServiceWorkerDatabase::STATUS_OK,

database->WriteRegistration(data, resources, &deleted_version,

@@ -511,7 +511,7 @@ TEST_F(ServiceWorkerDiskCacheMigratorTest, NotMigrateForEmptyDatabase) {

data.registration_id = 100;

data.scope = GURL("https://example.com/");

data.script = GURL("https://example.com/script.js");

- data.version_id = 200;

+ data.version_uuid = "84a19bb1-148b-484d-a3ff-1ab43ac3fe53";

data.resources_total_size_bytes = 10;

ASSERT_EQ(ServiceWorkerDatabase::STATUS_OK,

storage()->database_->WriteRegistration(