content/browser/service_worker/service_worker_context_observer.h - Issue 1221643014: Service Worker: Migrate to version_uuid and surface ServiceWorker.id. (Chromium 2/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_context_observer.h

Issue 1221643014: Service Worker: Migrate to version_uuid and surface ServiceWorker.id. (Chromium 2/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_context_core.cc ('k') | content/browser/service_worker/service_worker_context_request_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_context_observer.h

diff --git a/content/browser/service_worker/service_worker_context_observer.h b/content/browser/service_worker/service_worker_context_observer.h

index cf35d46b1b23f0dae196073700d87263e51c81f4..9e1f113c93d1b807ebf17512f38799b5baa39330 100644

--- a/content/browser/service_worker/service_worker_context_observer.h

+++ b/content/browser/service_worker/service_worker_context_observer.h

@@ -47,32 +47,33 @@ class ServiceWorkerContextObserver {

};

virtual void OnNewLiveRegistration(int64 registration_id,

const GURL& pattern) {}

- virtual void OnNewLiveVersion(int64 version_id,

+ virtual void OnNewLiveVersion(std::string version_uuid,

int64 registration_id,

const GURL& script_url) {}

virtual void OnRunningStateChanged(

- int64 version_id,

+ std::string version_uuid,

ServiceWorkerVersion::RunningStatus running_status) {}

- virtual void OnVersionStateChanged(int64 version_id,

+ virtual void OnVersionStateChanged(std::string version_uuid,

ServiceWorkerVersion::Status status) {}

virtual void OnMainScriptHttpResponseInfoSet(

- int64 version_id,

+ std::string version_uuid,

base::Time script_response_time,

base::Time script_last_modified) {}

- virtual void OnErrorReported(int64 version_id,

+ virtual void OnErrorReported(std::string version_uuid,

int process_id,

int thread_id,

const ErrorInfo& info) {}

- virtual void OnReportConsoleMessage(int64 version_id,

+ virtual void OnReportConsoleMessage(std::string version_uuid,

int process_id,

int thread_id,

const ConsoleMessage& message) {}

- virtual void OnControlleeAdded(int64 version_id,

+ virtual void OnControlleeAdded(std::string version_uuid,

const std::string& uuid,

int process_id,

int route_id,

ServiceWorkerProviderType type) {}

- virtual void OnControlleeRemoved(int64 version_id, const std::string& uuid) {}

+ virtual void OnControlleeRemoved(std::string version_uuid,

+ const std::string& uuid) {}

virtual void OnRegistrationStored(int64 registration_id,

const GURL& pattern) {}

virtual void OnRegistrationDeleted(int64 registration_id,