Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9343)

Unified Diff: content/browser/devtools/protocol/service_worker_handler.h

Issue 1221643014: Service Worker: Migrate to version_uuid and surface ServiceWorker.id. (Chromium 2/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/devtools/protocol/service_worker_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/protocol/service_worker_handler.h
diff --git a/content/browser/devtools/protocol/service_worker_handler.h b/content/browser/devtools/protocol/service_worker_handler.h
index 81cd71f834e52da91004f7369bb5a8ef0bc5b196..7dc9bbe457042e7e716d9a054103836d17f888c6 100644
--- a/content/browser/devtools/protocol/service_worker_handler.h
+++ b/content/browser/devtools/protocol/service_worker_handler.h
@@ -51,10 +51,10 @@ class ServiceWorkerHandler : public DevToolsAgentHostClient,
Response Stop(const std::string& worker_id);
Response Unregister(const std::string& scope_url);
Response StartWorker(const std::string& scope_url);
- Response StopWorker(const std::string& version_id);
+ Response StopWorker(const std::string& version_uuid);
Response UpdateRegistration(const std::string& scope_url);
- Response InspectWorker(const std::string& version_id);
- Response SkipWaiting(const std::string& version_id);
+ Response InspectWorker(const std::string& version_uuid);
+ Response SkipWaiting(const std::string& version_uuid);
Response SetDebugOnStart(bool debug_on_start);
Response DeliverPushMessage(const std::string& origin,
const std::string& registration_id,
@@ -84,7 +84,7 @@ class ServiceWorkerHandler : public DevToolsAgentHostClient,
void OnWorkerVersionUpdated(
const std::vector<ServiceWorkerVersionInfo>& registrations);
void OnErrorReported(int64 registration_id,
- int64 version_id,
+ std::string version_uuid,
const ServiceWorkerContextObserver::ErrorInfo& info);
void OpenNewDevToolsWindow(int process_id, int devtools_agent_route_id);
« no previous file with comments | « no previous file | content/browser/devtools/protocol/service_worker_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698