src/IceConverter.h - Issue 1221643012: Subzero: Add -Wshadow to the build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceConverter.h

Issue 1221643012: Subzero: Add -Wshadow to the build. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Code review changes Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/IceConverter.h

diff --git a/src/IceConverter.h b/src/IceConverter.h

index f2dbb3a5e627371c3bf9a399c32315b93c2f37a3..264cf4825ac0b16ed16fd6f77749eb59b4fba8e8 100644

--- a/src/IceConverter.h

+++ b/src/IceConverter.h

@@ -31,8 +31,8 @@ class Converter : public Translator {

Converter &operator=(const Converter &) = delete;

public:

- Converter(llvm::Module *Mod, GlobalContext *Ctx)

- : Translator(Ctx), Mod(Mod) {}

+ Converter(llvm::Module *MyMod, GlobalContext *MyCtx)

+ : Translator(MyCtx), Mod(MyMod) {}

~Converter() = default;