Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: src/IceCfg.cpp

Issue 1221643012: Subzero: Add -Wshadow to the build. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Code review changes Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceAssembler.h ('k') | src/IceCfgNode.h » ('j') | src/IceConverter.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceCfg.cpp
diff --git a/src/IceCfg.cpp b/src/IceCfg.cpp
index f7b1a8c6e0b99823230cf7263ba34521d5ada63f..bf7be51c1df74cc1921b86c1a347ec61780abb13 100644
--- a/src/IceCfg.cpp
+++ b/src/IceCfg.cpp
@@ -34,8 +34,8 @@ ArenaAllocator<> *getCurrentCfgAllocator() {
return Cfg::getCurrentCfgAllocator();
}
-Cfg::Cfg(GlobalContext *Ctx, uint32_t SequenceNumber)
- : Ctx(Ctx), SequenceNumber(SequenceNumber),
+Cfg::Cfg(GlobalContext *MyCtx, uint32_t MySequenceNumber)
+ : Ctx(MyCtx), SequenceNumber(MySequenceNumber),
VMask(Ctx->getFlags().getVerbose()), NextInstNumber(Inst::NumberInitial),
Allocator(new ArenaAllocator<>()), Live(nullptr),
Target(TargetLowering::createLowering(Ctx->getFlags().getTargetArch(),
@@ -567,7 +567,7 @@ void Cfg::emit() {
IceString MangledName = getContext()->mangleName(getFunctionName());
emitTextHeader(MangledName, Ctx, getAssembler<>());
for (CfgNode *Node : Nodes)
- Node->emit(this);
+ Node->emit();
Str << "\n";
}
@@ -576,7 +576,7 @@ void Cfg::emitIAS() {
// The emitIAS() routines emit into the internal assembler buffer,
// so there's no need to lock the streams.
for (CfgNode *Node : Nodes)
- Node->emitIAS(this);
+ Node->emitIAS();
}
// Dumps the IR with an optional introductory message.
@@ -620,7 +620,7 @@ void Cfg::dump(const IceString &Message) {
}
// Print each basic block
for (CfgNode *Node : Nodes)
- Node->dump(this);
+ Node->dump();
if (isVerbose(IceV_Instructions))
Str << "}\n";
}
« no previous file with comments | « src/IceAssembler.h ('k') | src/IceCfgNode.h » ('j') | src/IceConverter.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698