src/IceAPInt.h - Issue 1221643012: Subzero: Add -Wshadow to the build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceAPInt.h

Issue 1221643012: Subzero: Add -Wshadow to the build. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Code review changes Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/IceAPInt.h

diff --git a/src/IceAPInt.h b/src/IceAPInt.h

index 9ef0702186fe6d64ebe437bd5b011b1be5e7d7a2..9f35da489de511c8c99d37ac9a5e4d94a1184182 100644

--- a/src/IceAPInt.h

+++ b/src/IceAPInt.h

@@ -31,7 +31,7 @@ public:

/// Bits in an (internal) value.

static const SizeT APINT_BITS_PER_WORD = sizeof(uint64_t) * CHAR_BIT;

- APInt(SizeT Bits, uint64_t Val) : BitWidth(Bits), Val(Val) {

+ APInt(SizeT Bits, uint64_t MyVal) : BitWidth(Bits), Val(MyVal) {

assert(Bits && "bitwidth too small");

assert(Bits <= APINT_BITS_PER_WORD && "bitwidth too big");

clearUnusedBits();