Subzero: Add -Wshadow to the build.

src/IceInst.h

 //===- subzero/src/IceInst.h - High-level instructions ----------*- C++ -*-===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 ///
 /// \file
@@ skipping 377 matching lines @@
   Operand *getCallTarget() const { return getSrc(0); }
   Operand *getArg(SizeT I) const { return getSrc(I + 1); }
   SizeT getNumArgs() const { return getSrcSize() - 1; }
   bool isTailcall() const { return HasTailCall; }
   void dump(const Cfg *Func) const override;
   static bool classof(const Inst *Inst) { return Inst->getKind() == Call; }
   Type getReturnType() const;
 
 protected:
   InstCall(Cfg *Func, SizeT NumArgs, Variable *Dest, Operand *CallTarget,
-           bool HasTailCall, bool HasSideEff, InstKind Kind)
-      : InstHighLevel(Func, Kind, NumArgs + 1, Dest), HasTailCall(HasTailCall) {
+           bool MyHasTailCall, bool HasSideEff, InstKind Kind)

[jvoung (off chromium), 2015/07/14 01:25:19]

I suppose HasSideEff can be MyHasSideEffects (it was working around the
shadowing from the base class).

+      : InstHighLevel(Func, Kind, NumArgs + 1, Dest),
+        HasTailCall(MyHasTailCall) {
     HasSideEffects = HasSideEff;
     addSource(CallTarget);
   }
 
 private:
   bool HasTailCall;
 };
 
 /// Cast instruction (a.k.a. conversion operation).
 class InstCast : public InstHighLevel {
@@ skipping 149 matching lines @@
         InstIntrinsicCall(Func, NumArgs, Dest, CallTarget, Info);
   }
   static bool classof(const Inst *Inst) {
     return Inst->getKind() == IntrinsicCall;
   }
 
   Intrinsics::IntrinsicInfo getIntrinsicInfo() const { return Info; }
 
 private:
   InstIntrinsicCall(Cfg *Func, SizeT NumArgs, Variable *Dest,
-                    Operand *CallTarget, const Intrinsics::IntrinsicInfo &Info)
-      : InstCall(Func, NumArgs, Dest, CallTarget, false, Info.HasSideEffects,
+                    Operand *CallTarget,
+                    const Intrinsics::IntrinsicInfo &MyInfo)
+      : InstCall(Func, NumArgs, Dest, CallTarget, false, MyInfo.HasSideEffects,
                  Inst::IntrinsicCall),
-        Info(Info) {}
+        Info(MyInfo) {}
 
   const Intrinsics::IntrinsicInfo Info;
 };
 
 /// Load instruction.  The source address is captured in getSrc(0).
 class InstLoad : public InstHighLevel {
   InstLoad() = delete;
   InstLoad(const InstLoad &) = delete;
   InstLoad &operator=(const InstLoad &) = delete;
 
@@ skipping 354 matching lines @@
   static void noteHead(Ice::Inst *, Ice::Inst *) {}
   void deleteNode(Ice::Inst *) {}
 
 private:
   mutable ilist_half_node<Ice::Inst> Sentinel;
 };
 
 } // end of namespace llvm
 
 #endif // SUBZERO_SRC_ICEINST_H