Subzero: Add -Wshadow to the build.

src/IceInstARM32.h

 //===- subzero/src/IceInstARM32.h - ARM32 machine instructions --*- C++ -*-===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 //
 // This file declares the InstARM32 and OperandARM32 classes and
@@ skipping 278 matching lines @@
     Umull,
     Uxt
   };
 
   static const char *getWidthString(Type Ty);
   static CondARM32::Cond getOppositeCondition(CondARM32::Cond Cond);
 
   void dump(const Cfg *Func) const override;
 
 protected:
   InstARM32(Cfg *Func, InstKindARM32 Kind, SizeT Maxsrcs, Variable *Dest)

[Karl, 2015/07/07 17:00:40]

Again, I'm not sure what are the rules for naming parameters of constructors.
Why don't you use MyFunc, MyKind, MyMaxsrcs, and MyDest?

[John, 2015/07/07 17:07:49]

I believe the "My" prefix is only added when the parameter shadows the class
member.

[Jim Stichnoth, 2015/07/13 19:33:37]

Right.  The idea is that you generally name arguments as you like, but rename
them (perhaps using the My prefix) to fix warnings.

       : InstTarget(Func, static_cast<InstKind>(Kind), Maxsrcs, Dest) {}
 
   static bool isClassof(const Inst *Inst, InstKindARM32 MyKind) {
     return Inst->getKind() == static_cast<InstKind>(MyKind);
   }
 };
 
 // A predicable ARM instruction.
 class InstARM32Pred : public InstARM32 {
   InstARM32Pred() = delete;
   InstARM32Pred(const InstARM32Pred &) = delete;
   InstARM32Pred &operator=(const InstARM32Pred &) = delete;
 
 public:
   InstARM32Pred(Cfg *Func, InstKindARM32 Kind, SizeT Maxsrcs, Variable *Dest,
-                CondARM32::Cond Predicate)
-      : InstARM32(Func, Kind, Maxsrcs, Dest), Predicate(Predicate) {}
+                CondARM32::Cond MyPredicate)
+      : InstARM32(Func, Kind, Maxsrcs, Dest), Predicate(MyPredicate) {}
 
   CondARM32::Cond getPredicate() const { return Predicate; }
   void setPredicate(CondARM32::Cond Pred) { Predicate = Pred; }
 
   static const char *predString(CondARM32::Cond Predicate);
   void dumpOpcodePred(Ostream &Str, const char *Opcode, Type Ty) const;
 
   // Shared emit routines for common forms of instructions.
   static void emitUnaryopGPR(const char *Opcode, const InstARM32Pred *Inst,
                              const Cfg *Func);
@@ skipping 182 matching lines @@
     dumpDest(Func);
     Str << " = ";
     dumpOpcodePred(Str, Opcode, getDest()->getType());
     Str << (SetFlags ? ".s " : " ");
     dumpSources(Func);
   }
   static bool classof(const Inst *Inst) { return isClassof(Inst, K); }
 
 private:
   InstARM32ThreeAddrGPR(Cfg *Func, Variable *Dest, Variable *Src0,
-                        Operand *Src1, CondARM32::Cond Predicate, bool SetFlags)
-      : InstARM32Pred(Func, K, 2, Dest, Predicate), SetFlags(SetFlags) {
+                        Operand *Src1, CondARM32::Cond Predicate,
+                        bool MySetFlags)
+      : InstARM32Pred(Func, K, 2, Dest, Predicate), SetFlags(MySetFlags) {
     addSource(Src0);
     addSource(Src1);
   }
 
   static const char *Opcode;
   bool SetFlags;
 };
 
 // Instructions of the form x := a op1 (y op2 z). E.g., multiply accumulate.
 template <InstARM32::InstKindARM32 K>
@@ skipping 434 matching lines @@
 // Declare partial template specializations of emit() methods that
 // already have default implementations.  Without this, there is the
 // possibility of ODR violations and link errors.
 
 template <> void InstARM32Movw::emit(const Cfg *Func) const;
 template <> void InstARM32Movt::emit(const Cfg *Func) const;
 
 } // end of namespace Ice
 
 #endif // SUBZERO_SRC_ICEINSTARM32_H