Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Side by Side Diff: src/IceCompileServer.h

Issue 1221643012: Subzero: Add -Wshadow to the build. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Change the previous underscore naming style Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 //===- subzero/src/IceCompileServer.h - Compile server ----------*- C++ -*-===// 1 //===- subzero/src/IceCompileServer.h - Compile server ----------*- C++ -*-===//
2 // 2 //
3 // The Subzero Code Generator 3 // The Subzero Code Generator
4 // 4 //
5 // This file is distributed under the University of Illinois Open Source 5 // This file is distributed under the University of Illinois Open Source
6 // License. See LICENSE.TXT for details. 6 // License. See LICENSE.TXT for details.
7 // 7 //
8 //===----------------------------------------------------------------------===// 8 //===----------------------------------------------------------------------===//
9 // 9 //
10 // This file declares the compile server. Given a compiler implementation, 10 // This file declares the compile server. Given a compiler implementation,
(...skipping 25 matching lines...) Expand all
36 // 36 //
37 // When run on the commandline, it receives and therefore dispatches 37 // When run on the commandline, it receives and therefore dispatches
38 // the request immediately. When run in the browser, it blocks waiting 38 // the request immediately. When run in the browser, it blocks waiting
39 // for a request. 39 // for a request.
40 class CompileServer { 40 class CompileServer {
41 CompileServer() = delete; 41 CompileServer() = delete;
42 CompileServer(const CompileServer &) = delete; 42 CompileServer(const CompileServer &) = delete;
43 CompileServer &operator=(const CompileServer &) = delete; 43 CompileServer &operator=(const CompileServer &) = delete;
44 44
45 public: 45 public:
46 explicit CompileServer(Compiler &Comp) : Comp(Comp) {} 46 explicit CompileServer(Compiler &MyComp) : Comp(MyComp) {}
47 47
48 virtual ~CompileServer() = default; 48 virtual ~CompileServer() = default;
49 49
50 virtual void run() = 0; 50 virtual void run() = 0;
51 51
52 virtual ErrorCode &getErrorCode() { return LastError; } 52 virtual ErrorCode &getErrorCode() { return LastError; }
53 void transferErrorCode(ErrorCodes Code) { LastError.assign(Code); } 53 void transferErrorCode(ErrorCodes Code) { LastError.assign(Code); }
54 54
55 protected: 55 protected:
56 Compiler &getCompiler() const { return Comp; } 56 Compiler &getCompiler() const { return Comp; }
57 57
58 Compiler &Comp; 58 Compiler &Comp;
59 ErrorCode LastError; 59 ErrorCode LastError;
60 }; 60 };
61 61
62 // Commandline variant of the compile server. 62 // Commandline variant of the compile server.
63 class CLCompileServer : public CompileServer { 63 class CLCompileServer : public CompileServer {
64 CLCompileServer() = delete; 64 CLCompileServer() = delete;
65 CLCompileServer(const CLCompileServer &) = delete; 65 CLCompileServer(const CLCompileServer &) = delete;
66 CLCompileServer &operator=(const CLCompileServer &) = delete; 66 CLCompileServer &operator=(const CLCompileServer &) = delete;
67 67
68 public: 68 public:
69 CLCompileServer(Compiler &Comp, int argc, char **argv) 69 CLCompileServer(Compiler &Comp, int MyArgc, char **MyArgv)
70 : CompileServer(Comp), argc(argc), argv(argv) {} 70 : CompileServer(Comp), argc(MyArgc), argv(MyArgv) {}
71 71
72 ~CLCompileServer() final = default; 72 ~CLCompileServer() final = default;
73 73
74 void run() final; 74 void run() final;
75 75
76 private: 76 private:
77 int argc; 77 int argc;
78 char **argv; 78 char **argv;
79 std::unique_ptr<GlobalContext> Ctx; 79 std::unique_ptr<GlobalContext> Ctx;
80 }; 80 };
81 81
82 } // end of namespace Ice 82 } // end of namespace Ice
83 83
84 #endif // SUBZERO_SRC_ICECOMPILESERVER_H 84 #endif // SUBZERO_SRC_ICECOMPILESERVER_H
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698