Directly remove slot buffer entries in deoptimized code objects.

Directly remove slot buffer entries in deoptimized code objects.

BUG=

Committed: https://crrev.com/80b3f16951251d342ebaf9174872d50e46f048a5
Cr-Commit-Position: refs/heads/master@{#29379}

[Hannes Payer (out of office), 2015-06-30 08:44:56]

hpayer@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Michael Starzinger, 2015-06-30 08:54:19]

LGTM. Woot! I love it.

https://codereview.chromium.org/1221643004/diff/60001/src/deoptimizer.cc
File src/deoptimizer.cc (right):

https://codereview.chromium.org/1221643004/diff/60001/src/deoptimizer.cc#newc...
src/deoptimizer.cc:420:
code->GetHeap()->mark_compact_collector()->RemoveObjectSlots(code);
nit: Is there a particular reason we cannot use isolate->heap() here any longer
... otherwise I would vote for going back to it and inlining all into one single
line.

https://codereview.chromium.org/1221643004/diff/60001/src/heap/mark-compact.h
File src/heap/mark-compact.h (right):

https://codereview.chromium.org/1221643004/diff/60001/src/heap/mark-compact.h...
src/heap/mark-compact.h:737: void RemoveObjectSlots(HeapObject* invalid_object);
nit: The comment above this block doesn't really apply to this method, correct?
Can we add an empty newline to indicate that?

[Hannes Payer (out of office), 2015-06-30 09:02:10]

https://codereview.chromium.org/1221643004/diff/60001/src/deoptimizer.cc
File src/deoptimizer.cc (right):

https://codereview.chromium.org/1221643004/diff/60001/src/deoptimizer.cc#newc...
src/deoptimizer.cc:420:
code->GetHeap()->mark_compact_collector()->RemoveObjectSlots(code);
On 2015/06/30 08:54:19, Michael Starzinger wrote:
> nit: Is there a particular reason we cannot use isolate->heap() here any
longer
> ... otherwise I would vote for going back to it and inlining all into one
single
> line.

Done.

https://codereview.chromium.org/1221643004/diff/60001/src/heap/mark-compact.h
File src/heap/mark-compact.h (right):

https://codereview.chromium.org/1221643004/diff/60001/src/heap/mark-compact.h...
src/heap/mark-compact.h:737: void RemoveObjectSlots(HeapObject* invalid_object);
On 2015/06/30 08:54:19, Michael Starzinger wrote:
> nit: The comment above this block doesn't really apply to this method,
correct?
> Can we add an empty newline to indicate that?

Done.

[Hannes Payer (out of office), 2015-06-30 13:01:14]

The CQ bit was checked by hpayer@chromium.org

[Hannes Payer (out of office), 2015-06-30 13:01:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1221643004/#ps160001
(title: " ")

[commit-bot: I haz the power, 2015-06-30 13:01:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1221643004/160001

[commit-bot: I haz the power, 2015-06-30 13:32:08]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2015-06-30 13:32:21]

Patchset 9 (id:??) landed as
https://crrev.com/80b3f16951251d342ebaf9174872d50e46f048a5
Cr-Commit-Position: refs/heads/master@{#29379}