Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 1221503006: clang/win: Build without -Wno-missing-declarations. (Closed)

Created:
5 years, 5 months ago by Sam McNally
Modified:
5 years, 5 months ago
Reviewers:
Nico
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang/win: Build without -Wno-missing-declarations. BUG=505298 Committed: https://crrev.com/b048fb82ff50c605c41ee953ea2ba579a480550c Cr-Commit-Position: refs/heads/master@{#336966}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Sam McNally
5 years, 5 months ago (2015-07-01 01:37:06 UTC) #2
Nico
lgtm
5 years, 5 months ago (2015-07-01 01:59:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1221503006/1
5 years, 5 months ago (2015-07-01 02:31:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-01 03:35:29 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-01 03:36:39 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b048fb82ff50c605c41ee953ea2ba579a480550c
Cr-Commit-Position: refs/heads/master@{#336966}

Powered by Google App Engine
This is Rietveld 408576698