Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Side by Side Diff: content/browser/service_worker/embedded_worker_instance.cc

Issue 1221503003: Add a mojo ServiceRegistry to embedded workers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add comment to BindServiceRegistry Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/browser/service_worker/embedded_worker_instance.h ('k') | content/common/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/service_worker/embedded_worker_instance.h" 5 #include "content/browser/service_worker/embedded_worker_instance.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
11 #include "base/metrics/histogram_macros.h" 11 #include "base/metrics/histogram_macros.h"
12 #include "base/threading/non_thread_safe.h" 12 #include "base/threading/non_thread_safe.h"
13 #include "base/trace_event/trace_event.h" 13 #include "base/trace_event/trace_event.h"
14 #include "content/browser/devtools/service_worker_devtools_manager.h" 14 #include "content/browser/devtools/service_worker_devtools_manager.h"
15 #include "content/browser/service_worker/embedded_worker_registry.h" 15 #include "content/browser/service_worker/embedded_worker_registry.h"
16 #include "content/browser/service_worker/service_worker_context_core.h" 16 #include "content/browser/service_worker/service_worker_context_core.h"
17 #include "content/common/content_switches_internal.h" 17 #include "content/common/content_switches_internal.h"
18 #include "content/common/mojo/service_registry_impl.h"
18 #include "content/common/service_worker/embedded_worker_messages.h" 19 #include "content/common/service_worker/embedded_worker_messages.h"
20 #include "content/common/service_worker/embedded_worker_setup.mojom.h"
19 #include "content/common/service_worker/service_worker_types.h" 21 #include "content/common/service_worker/service_worker_types.h"
20 #include "content/public/browser/browser_thread.h" 22 #include "content/public/browser/browser_thread.h"
21 #include "content/public/browser/render_process_host.h" 23 #include "content/public/browser/render_process_host.h"
22 #include "ipc/ipc_message.h" 24 #include "ipc/ipc_message.h"
23 #include "url/gurl.h" 25 #include "url/gurl.h"
24 26
25 namespace content { 27 namespace content {
26 28
27 namespace { 29 namespace {
28 30
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 service_worker_context_weak, 78 service_worker_context_weak,
77 service_worker_version_id, 79 service_worker_version_id,
78 url)); 80 url));
79 } 81 }
80 BrowserThread::PostTask( 82 BrowserThread::PostTask(
81 BrowserThread::IO, 83 BrowserThread::IO,
82 FROM_HERE, 84 FROM_HERE,
83 base::Bind(callback, worker_devtools_agent_route_id, wait_for_debugger)); 85 base::Bind(callback, worker_devtools_agent_route_id, wait_for_debugger));
84 } 86 }
85 87
88 void SetupMojoOnUIThread(int process_id,
89 int thread_id,
90 mojo::InterfaceRequest<mojo::ServiceProvider> services,
91 mojo::ServiceProviderPtr exposed_services) {
92 RenderProcessHost* rph = RenderProcessHost::FromID(process_id);
93 // |rph| may be NULL in unit tests.
94 if (!rph)
95 return;
96 EmbeddedWorkerSetupPtr setup;
97 rph->GetServiceRegistry()->ConnectToRemoteService(mojo::GetProxy(&setup));
98 setup->ExchangeServiceProviders(thread_id, services.Pass(),
99 exposed_services.Pass());
100 }
101
86 } // namespace 102 } // namespace
87 103
88 // Lives on IO thread, proxies notifications to DevToolsManager that lives on 104 // Lives on IO thread, proxies notifications to DevToolsManager that lives on
89 // UI thread. Owned by EmbeddedWorkerInstance. 105 // UI thread. Owned by EmbeddedWorkerInstance.
90 class EmbeddedWorkerInstance::DevToolsProxy : public base::NonThreadSafe { 106 class EmbeddedWorkerInstance::DevToolsProxy : public base::NonThreadSafe {
91 public: 107 public:
92 DevToolsProxy(int process_id, int agent_route_id) 108 DevToolsProxy(int process_id, int agent_route_id)
93 : process_id_(process_id), 109 : process_id_(process_id),
94 agent_route_id_(agent_route_id) {} 110 agent_route_id_(agent_route_id) {}
95 111
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
138 const StatusCallback& callback) { 154 const StatusCallback& callback) {
139 if (!context_) { 155 if (!context_) {
140 callback.Run(SERVICE_WORKER_ERROR_ABORT); 156 callback.Run(SERVICE_WORKER_ERROR_ABORT);
141 return; 157 return;
142 } 158 }
143 DCHECK(status_ == STOPPED); 159 DCHECK(status_ == STOPPED);
144 start_timing_ = base::TimeTicks::Now(); 160 start_timing_ = base::TimeTicks::Now();
145 status_ = STARTING; 161 status_ = STARTING;
146 starting_phase_ = ALLOCATING_PROCESS; 162 starting_phase_ = ALLOCATING_PROCESS;
147 network_accessed_for_script_ = false; 163 network_accessed_for_script_ = false;
164 service_registry_.reset(new ServiceRegistryImpl());
148 FOR_EACH_OBSERVER(Listener, listener_list_, OnStarting()); 165 FOR_EACH_OBSERVER(Listener, listener_list_, OnStarting());
149 scoped_ptr<EmbeddedWorkerMsg_StartWorker_Params> params( 166 scoped_ptr<EmbeddedWorkerMsg_StartWorker_Params> params(
150 new EmbeddedWorkerMsg_StartWorker_Params()); 167 new EmbeddedWorkerMsg_StartWorker_Params());
151 TRACE_EVENT_ASYNC_BEGIN2("ServiceWorker", 168 TRACE_EVENT_ASYNC_BEGIN2("ServiceWorker",
152 "EmbeddedWorkerInstance::ProcessAllocate", 169 "EmbeddedWorkerInstance::ProcessAllocate",
153 params.get(), 170 params.get(),
154 "Scope", scope.spec(), 171 "Scope", scope.spec(),
155 "Script URL", script_url.spec()); 172 "Script URL", script_url.spec());
156 params->embedded_worker_id = embedded_worker_id_; 173 params->embedded_worker_id = embedded_worker_id_;
157 params->service_worker_version_id = service_worker_version_id; 174 params->service_worker_version_id = service_worker_version_id;
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
195 ServiceWorkerStatusCode EmbeddedWorkerInstance::SendMessage( 212 ServiceWorkerStatusCode EmbeddedWorkerInstance::SendMessage(
196 const IPC::Message& message) { 213 const IPC::Message& message) {
197 DCHECK_NE(kInvalidEmbeddedWorkerThreadId, thread_id_); 214 DCHECK_NE(kInvalidEmbeddedWorkerThreadId, thread_id_);
198 if (status_ != RUNNING && status_ != STARTING) 215 if (status_ != RUNNING && status_ != STARTING)
199 return SERVICE_WORKER_ERROR_IPC_FAILED; 216 return SERVICE_WORKER_ERROR_IPC_FAILED;
200 return registry_->Send(process_id_, 217 return registry_->Send(process_id_,
201 new EmbeddedWorkerContextMsg_MessageToWorker( 218 new EmbeddedWorkerContextMsg_MessageToWorker(
202 thread_id_, embedded_worker_id_, message)); 219 thread_id_, embedded_worker_id_, message));
203 } 220 }
204 221
222 ServiceRegistry* EmbeddedWorkerInstance::GetServiceRegistry() {
223 DCHECK(status_ == STARTING || status_ == RUNNING) << status_;
224 return service_registry_.get();
225 }
226
205 EmbeddedWorkerInstance::EmbeddedWorkerInstance( 227 EmbeddedWorkerInstance::EmbeddedWorkerInstance(
206 base::WeakPtr<ServiceWorkerContextCore> context, 228 base::WeakPtr<ServiceWorkerContextCore> context,
207 int embedded_worker_id) 229 int embedded_worker_id)
208 : context_(context), 230 : context_(context),
209 registry_(context->embedded_worker_registry()), 231 registry_(context->embedded_worker_registry()),
210 embedded_worker_id_(embedded_worker_id), 232 embedded_worker_id_(embedded_worker_id),
211 status_(STOPPED), 233 status_(STOPPED),
212 starting_phase_(NOT_STARTING), 234 starting_phase_(NOT_STARTING),
213 process_id_(-1), 235 process_id_(-1),
214 thread_id_(kInvalidEmbeddedWorkerThreadId), 236 thread_id_(kInvalidEmbeddedWorkerThreadId),
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
250 bool is_new_process, 272 bool is_new_process,
251 ServiceWorkerStatusCode status) { 273 ServiceWorkerStatusCode status) {
252 DCHECK_EQ(process_id_, -1); 274 DCHECK_EQ(process_id_, -1);
253 TRACE_EVENT_ASYNC_END1("ServiceWorker", 275 TRACE_EVENT_ASYNC_END1("ServiceWorker",
254 "EmbeddedWorkerInstance::ProcessAllocate", 276 "EmbeddedWorkerInstance::ProcessAllocate",
255 params.get(), 277 params.get(),
256 "Status", status); 278 "Status", status);
257 if (status != SERVICE_WORKER_OK) { 279 if (status != SERVICE_WORKER_OK) {
258 Status old_status = status_; 280 Status old_status = status_;
259 status_ = STOPPED; 281 status_ = STOPPED;
282 service_registry_.reset();
260 callback.Run(status); 283 callback.Run(status);
261 FOR_EACH_OBSERVER(Listener, listener_list_, OnStopped(old_status)); 284 FOR_EACH_OBSERVER(Listener, listener_list_, OnStopped(old_status));
262 return; 285 return;
263 } 286 }
264 const int64 service_worker_version_id = params->service_worker_version_id; 287 const int64 service_worker_version_id = params->service_worker_version_id;
265 process_id_ = process_id; 288 process_id_ = process_id;
266 GURL script_url(params->script_url); 289 GURL script_url(params->script_url);
267 290
268 // Register this worker to DevToolsManager on UI thread, then continue to 291 // Register this worker to DevToolsManager on UI thread, then continue to
269 // call SendStartWorker on IO thread. 292 // call SendStartWorker on IO thread.
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
337 UMA_HISTOGRAM_TIMES( 360 UMA_HISTOGRAM_TIMES(
338 "EmbeddedWorkerInstance.ScriptLoadWithoutNetworkAccess", 361 "EmbeddedWorkerInstance.ScriptLoadWithoutNetworkAccess",
339 base::TimeTicks::Now() - start_timing_); 362 base::TimeTicks::Now() - start_timing_);
340 } 363 }
341 // Reset |start_timing_| to measure the time excluding the process 364 // Reset |start_timing_| to measure the time excluding the process
342 // allocation time and the script loading time. 365 // allocation time and the script loading time.
343 start_timing_ = base::TimeTicks::Now(); 366 start_timing_ = base::TimeTicks::Now();
344 } 367 }
345 thread_id_ = thread_id; 368 thread_id_ = thread_id;
346 FOR_EACH_OBSERVER(Listener, listener_list_, OnScriptLoaded()); 369 FOR_EACH_OBSERVER(Listener, listener_list_, OnScriptLoaded());
370
371 mojo::ServiceProviderPtr exposed_services;
372 service_registry_->Bind(GetProxy(&exposed_services));
373 mojo::ServiceProviderPtr services;
374 mojo::InterfaceRequest<mojo::ServiceProvider> services_request =
375 GetProxy(&services);
376 BrowserThread::PostTask(
377 BrowserThread::UI, FROM_HERE,
378 base::Bind(SetupMojoOnUIThread, process_id_, thread_id_,
379 base::Passed(&services_request),
380 base::Passed(&exposed_services)));
381 service_registry_->BindRemoteServiceProvider(services.Pass());
347 } 382 }
348 383
349 void EmbeddedWorkerInstance::OnScriptLoadFailed() { 384 void EmbeddedWorkerInstance::OnScriptLoadFailed() {
350 } 385 }
351 386
352 void EmbeddedWorkerInstance::OnScriptEvaluated(bool success) { 387 void EmbeddedWorkerInstance::OnScriptEvaluated(bool success) {
353 starting_phase_ = SCRIPT_EVALUATED; 388 starting_phase_ = SCRIPT_EVALUATED;
354 if (start_callback_.is_null()) { 389 if (start_callback_.is_null()) {
355 DVLOG(1) << "Received unexpected OnScriptEvaluated message."; 390 DVLOG(1) << "Received unexpected OnScriptEvaluated message.";
356 return; 391 return;
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
442 network_accessed_for_script_ = true; 477 network_accessed_for_script_ = true;
443 } 478 }
444 479
445 void EmbeddedWorkerInstance::ReleaseProcess() { 480 void EmbeddedWorkerInstance::ReleaseProcess() {
446 devtools_proxy_.reset(); 481 devtools_proxy_.reset();
447 if (context_) 482 if (context_)
448 context_->process_manager()->ReleaseWorkerProcess(embedded_worker_id_); 483 context_->process_manager()->ReleaseWorkerProcess(embedded_worker_id_);
449 status_ = STOPPED; 484 status_ = STOPPED;
450 process_id_ = -1; 485 process_id_ = -1;
451 thread_id_ = -1; 486 thread_id_ = -1;
487 service_registry_.reset();
452 start_callback_.Reset(); 488 start_callback_.Reset();
453 } 489 }
454 490
455 // static 491 // static
456 std::string EmbeddedWorkerInstance::StatusToString(Status status) { 492 std::string EmbeddedWorkerInstance::StatusToString(Status status) {
457 switch (status) { 493 switch (status) {
458 case STOPPED: 494 case STOPPED:
459 return "STOPPED"; 495 return "STOPPED";
460 case STARTING: 496 case STARTING:
461 return "STARTING"; 497 return "STARTING";
(...skipping 24 matching lines...) Expand all
486 case SCRIPT_EVALUATED: 522 case SCRIPT_EVALUATED:
487 return "Script evaluated"; 523 return "Script evaluated";
488 case STARTING_PHASE_MAX_VALUE: 524 case STARTING_PHASE_MAX_VALUE:
489 NOTREACHED(); 525 NOTREACHED();
490 } 526 }
491 NOTREACHED() << phase; 527 NOTREACHED() << phase;
492 return std::string(); 528 return std::string();
493 } 529 }
494 530
495 } // namespace content 531 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/service_worker/embedded_worker_instance.h ('k') | content/common/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698