Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1621)

Unified Diff: chrome/browser/extensions/api/tab_capture/tab_capture_registry.h

Issue 1221483002: New tabCapture.captureOffscreenTab API, initially for Presentation API 1UA mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Mostly revert to Patch Set 6, plus minor tweaks. [and REBASE] Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/tab_capture/tab_capture_registry.h
diff --git a/chrome/browser/extensions/api/tab_capture/tab_capture_registry.h b/chrome/browser/extensions/api/tab_capture/tab_capture_registry.h
index 60d5f2b6b9f4ac72ca5ddfd22fb002405d92bc9d..b953f25c0b3733689417a2dff5a7998a8a5b8c0b 100644
--- a/chrome/browser/extensions/api/tab_capture/tab_capture_registry.h
+++ b/chrome/browser/extensions/api/tab_capture/tab_capture_registry.h
@@ -49,9 +49,16 @@ class TabCaptureRegistry : public BrowserContextKeyedAPI,
// Add a tab capture request to the registry when a stream is requested
// through the API. |target_contents| refers to the WebContents associated
// with the tab to be captured. |extension_id| refers to the Extension
- // initiating the request.
+ // initiating the request. |is_anonymous| is true if GetCapturedTabs() should
+ // not list the captured tab, and no status change events should be dispatched
+ // for it.
+ //
+ // TODO(miu): This is broken in that it's possible for a later WebContents
+ // instance to have the same pointer value as a previously-destroyed one. To
+ // be fixed while working on http://crbug.com/163100.
bool AddRequest(content::WebContents* target_contents,
- const std::string& extension_id);
+ const std::string& extension_id,
+ bool is_anonymous);
// Called by MediaStreamDevicesController to verify the request before
// creating the stream. |render_process_id| and |render_frame_id| are used to

Powered by Google App Engine
This is Rietveld 408576698