Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 1221473003: content: Fix single process support for native GpuMemoryBuffers. (Closed)

Created:
5 years, 6 months ago by reveman
Modified:
5 years, 5 months ago
Reviewers:
piman
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, vignatti (out of this project)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

content: Fix single process support for native GpuMemoryBuffers. Also add the startup message filter for CreateGpuMemoryBuffer messages in single process mode. BUG=497559, 504121 Committed: https://crrev.com/29ec87df6cef29b9f28dd21d385f16ce99df9ce3 Cr-Commit-Position: refs/heads/master@{#336495}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -11 lines) Patch
M content/gpu/gpu_child_thread.h View 1 chunk +4 lines, -1 line 0 comments Download
M content/gpu/gpu_child_thread.cc View 2 chunks +15 lines, -2 lines 0 comments Download
M content/gpu/gpu_main.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M content/gpu/in_process_gpu_thread.h View 2 chunks +3 lines, -1 line 0 comments Download
M content/gpu/in_process_gpu_thread.cc View 3 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
reveman
5 years, 6 months ago (2015-06-26 20:11:00 UTC) #2
piman
lgtm
5 years, 6 months ago (2015-06-27 01:32:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1221473003/1
5 years, 5 months ago (2015-06-27 13:37:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-06-27 13:48:27 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/29ec87df6cef29b9f28dd21d385f16ce99df9ce3 Cr-Commit-Position: refs/heads/master@{#336495}
5 years, 5 months ago (2015-06-27 13:49:36 UTC) #7
kcarattini
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1210073003/ by kcarattini@chromium.org. ...
5 years, 5 months ago (2015-06-29 05:45:32 UTC) #8
grt (UTC plus 2)
5 years, 5 months ago (2015-06-29 13:52:46 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1217853002/ by grt@chromium.org.

The reason for reverting is: Speculative revert to see if this is what broke XP
Tests (1)..

Powered by Google App Engine
This is Rietveld 408576698