Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 1221433022: PPC: perf enhancement: Use larger heap page size on PPC. (Closed)

Created:
5 years, 5 months ago by dstence
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: perf enhancement: Use larger heap page size on PPC. Revisit of https://codereview.chromium.org/910333004. Use 4MB heap page size over the default of 1MB. This change provides an improvement of 1.86% on the composite octane benchmark score on PPC. This is 0.56% more than if --min_semi_space_size=4 was used to specify a 4MB heap page size. Additionally, two more tests required modification to account for configurable heap page size. R=svenpanne@chromium.org, hpayer@chromium.org, danno@chromium.org, mbrandy@us.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/bb3bb6b773dc91741f9386fca433b81ec02c72c6 Cr-Commit-Position: refs/heads/master@{#29775}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -13 lines) Patch
M src/base/build_config.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 6 chunks +17 lines, -9 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M test/cctest/test-strings.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
dstence
5 years, 5 months ago (2015-07-08 17:36:15 UTC) #1
Hannes Payer (out of office)
lgtm
5 years, 5 months ago (2015-07-21 06:52:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1221433022/1
5 years, 5 months ago (2015-07-21 15:04:39 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-21 15:52:09 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 15:52:24 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb3bb6b773dc91741f9386fca433b81ec02c72c6
Cr-Commit-Position: refs/heads/master@{#29775}

Powered by Google App Engine
This is Rietveld 408576698