Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 1221433010: Move compatible receiver check from CompileHandler to UpdateCaches (Closed)

Created:
5 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 5 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move compatible receiver check from CompileHandler to UpdateCaches We also need to do the check before using an existing handler from the cache BUG=chromium:505374 R=verwaest@chromium.org LOG=y Committed: https://crrev.com/8c298c79c2eff50b1d3809a5f72ed7d3679c47a4 Cr-Commit-Position: refs/heads/master@{#29511}

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates #

Patch Set 3 : updates #

Patch Set 4 : updates #

Patch Set 5 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -5 lines) Patch
M src/ic/ic.cc View 1 2 3 4 3 chunks +43 lines, -5 lines 0 comments Download
M test/cctest/test-api.cc View 1 1 chunk +39 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
jochen (gone - plz use gerrit)
5 years, 5 months ago (2015-07-06 11:21:55 UTC) #1
jochen (gone - plz use gerrit)
ptal fixes the bug when I patch it locally into a chromium checkout. any idea ...
5 years, 5 months ago (2015-07-06 11:22:29 UTC) #2
Toon Verwaest
https://codereview.chromium.org/1221433010/diff/1/src/ic/ic.cc File src/ic/ic.cc (right): https://codereview.chromium.org/1221433010/diff/1/src/ic/ic.cc#newcode1102 src/ic/ic.cc:1102: Handle<Object> value) { Just move this code into LoadIC::UpdateCaches, ...
5 years, 5 months ago (2015-07-06 11:49:18 UTC) #3
Toon Verwaest
To test from V8 you'll have to write a cctest.
5 years, 5 months ago (2015-07-06 11:49:50 UTC) #4
jochen (gone - plz use gerrit)
ptal
5 years, 5 months ago (2015-07-06 17:22:34 UTC) #5
Toon Verwaest
lgtm
5 years, 5 months ago (2015-07-07 10:28:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1221433010/80001
5 years, 5 months ago (2015-07-07 10:34:20 UTC) #8
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 5 months ago (2015-07-07 11:02:21 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-07 11:02:42 UTC) #10
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/8c298c79c2eff50b1d3809a5f72ed7d3679c47a4
Cr-Commit-Position: refs/heads/master@{#29511}

Powered by Google App Engine
This is Rietveld 408576698