Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4245)

Unified Diff: cc/resources/resource_provider.cc

Issue 1221433002: cc: narrow ChromeOS perf workaround to ARM (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: narrow ChromeOS perf workaround to ARM Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/raster/one_copy_tile_task_worker_pool.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/resources/resource_provider.cc
diff --git a/cc/resources/resource_provider.cc b/cc/resources/resource_provider.cc
index d83739093a509bb2eb6e5c3f29f4900ad513a0e1..66a68fa9c3873fc9b3256335e040211bacd6ea45 100644
--- a/cc/resources/resource_provider.cc
+++ b/cc/resources/resource_provider.cc
@@ -1590,10 +1590,10 @@ void ResourceProvider::LazyCreateImage(Resource* resource) {
GLES2Interface* gl = ContextGL();
DCHECK(gl);
-#if defined(OS_CHROMEOS)
- // TODO(reveman): GL_COMMANDS_ISSUED_CHROMIUM is used for synchronization
- // on ChromeOS to avoid some performance issues. This only works with
- // shared memory backed buffers. crbug.com/436314
+#if defined(OS_CHROMEOS) && defined(ARCH_CPU_ARM_FAMILY)
+ // TODO(reveman): This avoids a performance problem on ARM ChromeOS
+ // devices. This only works with shared memory backed buffers.
+ // crbug.com/580166
DCHECK_EQ(resource->gpu_memory_buffer->GetHandle().type,
gfx::SHARED_MEMORY_BUFFER);
#endif
« no previous file with comments | « cc/raster/one_copy_tile_task_worker_pool.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698