Issue 1221383003: Fix performance regression introduced in r28961

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1221383003: Fix performance regression introduced in r28961 (Closed)

Created:
5 years, 5 months ago by Jakob Kummerow

Modified:
5 years, 5 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev, arv (Not doing code reviews)

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Fix performance regression introduced in r28961 where bound functions' length was made configurable. The bootstrapper must be kept in sync to avoid polymorphism. BUG=chromium:500686 LOG=n R=verwaest@chromium.org Committed: https://crrev.com/d45803b52678ad8a5460e571bce9f01324e08fc5 Cr-Commit-Position: refs/heads/master@{#29496}

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	src/bootstrapper.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/runtime/runtime-function.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 7 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1221383003/1

5 years, 5 months ago (2015-07-06 15:04:15 UTC) #4

arv (Not doing code reviews)

Thanks. That comment would have been useful when I did the initial change.

5 years, 5 months ago (2015-07-06 15:28:38 UTC) #5

commit-bot: I haz the power

5 years, 5 months ago (2015-07-06 15:29:39 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/d45803b52678ad8a5460e571bce9f01324e08fc5
Cr-Commit-Position: refs/heads/master@{#29496}