Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1221363002: Wrap elements.cc in an anonymous namespace (Closed)

Created:
5 years, 5 months ago by Toon Verwaest
Modified:
5 years, 5 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Wrap elements.cc in an anonymous namespace BUG= Committed: https://crrev.com/9599bad42004003a67de974495e8b933190ec624 Cr-Commit-Position: refs/heads/master@{#29484}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -68 lines) Patch
M src/elements.cc View 1 6 chunks +68 lines, -66 lines 0 comments Download
M src/objects.h View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Toon Verwaest
ptal
5 years, 5 months ago (2015-07-06 10:07:50 UTC) #2
Igor Sheludko
lgtm
5 years, 5 months ago (2015-07-06 10:10:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1221363002/20001
5 years, 5 months ago (2015-07-06 10:14:39 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-06 10:40:27 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-06 10:40:47 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9599bad42004003a67de974495e8b933190ec624
Cr-Commit-Position: refs/heads/master@{#29484}

Powered by Google App Engine
This is Rietveld 408576698