Add support for escaped target names in isolate driver (4th try)

Add support for escaped target names in isolate driver (4th try)

Currently the isolate_driver.py which creates the dependency files
used by the isolate system, does a simple split on all spaces when
trying to identify targets.

This can fail if the target name contains a space in the name. In
ninja, spaces are escaped with a $-prefix. An example would be
'Content$ Shell$ Helper.app'.

This CL adds support for such target names and ensures that they
stay as one item. Doing this uncovered a few missing dependencies
and a missing file in some .isolate-files for the component build
on Mac.

1st try: https://codereview.chromium.org/970203003/
1st revert: https://codereview.chromium.org/985753002/
2nd try: https://codereview.chromium.org/1103793002/
2nd revert: https://codereview.chromium.org/1129493003/
3rd try: https://codereview.chromium.org/1130523003/
3rd revert: https://codereview.chromium.org/1131363003/
BUG=462248
Committed: https://crrev.com/c58992cc880b5bff5813276ee9d20a79be70b31f
Cr-Commit-Position: refs/heads/master@{#338402}

[nyquist, 2015-07-07 21:23:04]

The CQ bit was checked by nyquist@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-07 21:23:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1221333013/1

[commit-bot: I haz the power, 2015-07-07 23:54:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-07 23:54:29]

Dry run: Exceeded global retry quota

[nyquist, 2015-07-08 16:12:38]

The CQ bit was checked by nyquist@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-08 16:13:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1221333013/20001

[commit-bot: I haz the power, 2015-07-08 17:21:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-08 17:21:01]

Dry run: This issue passed the CQ dry run.

[nyquist, 2015-07-08 17:33:36]

nyquist@chromium.org changed reviewers:
+ thakis@chromium.org, vadimsh@chromium.org

[nyquist, 2015-07-08 17:33:36]

thakis: PTAL chrome/
vadimsh: PTAL tools/

[Vadim Sh., 2015-07-08 17:37:30]

lgtm

[nyquist, 2015-07-10 18:21:26]

thakis: Friendly ping.

[Nico, 2015-07-10 21:11:26]

lgtm

[nyquist, 2015-07-10 21:41:52]

The CQ bit was checked by nyquist@chromium.org

[commit-bot: I haz the power, 2015-07-10 21:43:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1221333013/20001

[commit-bot: I haz the power, 2015-07-11 00:01:28]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-07-11 00:02:24]

Patchset 2 (id:??) landed as
https://crrev.com/c58992cc880b5bff5813276ee9d20a79be70b31f
Cr-Commit-Position: refs/heads/master@{#338402}

[Noel Gordon, 2015-07-13 11:29:38]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1227843004/ by noel@chromium.org.

The reason for reverting is: Speculative revert: appreas to have broken the GPU
mac builders.

http://build.chromium.org/p/chromium.webkit/builders/GPU%20Mac%2010.9%20%28In...
.. 11141


.

[Noel Gordon, 2015-07-13 12:36:43]

On 2015/07/13 11:29:38, noel gordon wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/1227843004/ by mailto:noel@chromium.org.
> 
> The reason for reverting is: Speculative revert: appreas to have broken the
GPU
> mac builders.
> 
>
http://build.chromium.org/p/chromium.webkit/builders/GPU%20Mac%2010.9%20%28In...
> .. 11141

FYI: next build after revert went green.

http://build.chromium.org/p/chromium.webkit/builders/GPU%20Mac%2010.9%20%28In...

http://build.chromium.org/p/chromium.webkit/builders/GPU%20Mac10.7%20%28dbg%2...