Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 1221333010: Removed -Wno-overloaded-virtual warning suppression. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@wno-overloaded-virtual-fixes
Patch Set: Update comment to refer to this bug. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 if (current_cpu == "arm") { 7 if (current_cpu == "arm") {
8 import("//build/config/arm.gni") 8 import("//build/config/arm.gni")
9 } 9 }
10 if (current_cpu == "mipsel" || current_cpu == "mips64el") { 10 if (current_cpu == "mipsel" || current_cpu == "mips64el") {
(...skipping 788 matching lines...) Expand 10 before | Expand all | Expand 10 after
799 default_warning_flags += [ 799 default_warning_flags += [
800 # TODO(hans): Make this list shorter eventually, http://crbug.com/504657 800 # TODO(hans): Make this list shorter eventually, http://crbug.com/504657
801 "-Qunused-arguments", # http://crbug.com/504658 801 "-Qunused-arguments", # http://crbug.com/504658
802 "-Wno-empty-body", # http://crbug.com/504661 802 "-Wno-empty-body", # http://crbug.com/504661
803 "-Wno-extra-tokens", # http://crbug.com/504663 803 "-Wno-extra-tokens", # http://crbug.com/504663
804 "-Wno-incompatible-pointer-types", # http://crbug.com/504696 804 "-Wno-incompatible-pointer-types", # http://crbug.com/504696
805 "-Wno-logical-op-parentheses", # http://crbug.com/504699 805 "-Wno-logical-op-parentheses", # http://crbug.com/504699
806 "-Wno-microsoft", # http://crbug.com/505296 806 "-Wno-microsoft", # http://crbug.com/505296
807 "-Wno-missing-braces", # http://crbug.com/505297 807 "-Wno-missing-braces", # http://crbug.com/505297
808 "-Wno-msvc-include", # http://crbug.com/505299 808 "-Wno-msvc-include", # http://crbug.com/505299
809 "-Wno-overloaded-virtual", # http://crbug.com/505301
810 "-Wno-pointer-sign", # http://crbug.com/505303 809 "-Wno-pointer-sign", # http://crbug.com/505303
811 "-Wno-reorder", # http://crbug.com/505304 810 "-Wno-reorder", # http://crbug.com/505304
812 "-Wno-switch", # http://crbug.com/505308 811 "-Wno-switch", # http://crbug.com/505308
813 "-Wno-unknown-pragmas", # http://crbug.com/505314 812 "-Wno-unknown-pragmas", # http://crbug.com/505314
814 "-Wno-unused-function", # http://crbug.com/505316 813 "-Wno-unused-function", # http://crbug.com/505316
815 "-Wno-unused-private-field", # http://crbug.com/505317 814 "-Wno-unused-private-field", # http://crbug.com/505317
816 "-Wno-unused-value", # http://crbug.com/505318 815 "-Wno-unused-value", # http://crbug.com/505318
817 "-Wno-unused-variable", # http://crbug.com/505319 816 "-Wno-unused-variable", # http://crbug.com/505319
818 "-Wno-unused-local-typedef", # http://crbug.com/411648 817 "-Wno-unused-local-typedef", # http://crbug.com/411648
819 ] 818 ]
(...skipping 168 matching lines...) Expand 10 before | Expand all | Expand 10 after
988 } 987 }
989 988
990 if (is_linux) { 989 if (is_linux) {
991 # Don't warn about ignoring the return value from e.g. close(). This is 990 # Don't warn about ignoring the return value from e.g. close(). This is
992 # off by default in some gccs but on by default in others. BSD systems do 991 # off by default in some gccs but on by default in others. BSD systems do
993 # not support this option, since they are usually using gcc 4.2.1, which 992 # not support this option, since they are usually using gcc 4.2.1, which
994 # does not have this flag yet. 993 # does not have this flag yet.
995 cflags += [ "-Wno-unused-result" ] 994 cflags += [ "-Wno-unused-result" ]
996 } 995 }
997 996
997 if (is_clang) {
998 cflags += [
999 # TODO(mgiuca): Move this suppression into individual third-party
1000 # libraries as required. http://crbug.com/505301.
1001 "-Wno-overloaded-virtual",
1002 ]
1003 }
1004
998 if (is_linux || is_android) { 1005 if (is_linux || is_android) {
999 cflags += [ 1006 cflags += [
1000 # Don't warn about printf format problems. This is off by default in gcc 1007 # Don't warn about printf format problems. This is off by default in gcc
1001 # but on in Ubuntu's gcc(!). 1008 # but on in Ubuntu's gcc(!).
1002 "-Wno-format", 1009 "-Wno-format",
1003 ] 1010 ]
1004 cflags_cc += [ 1011 cflags_cc += [
1005 # Don't warn about hash_map in third-party code. 1012 # Don't warn about hash_map in third-party code.
1006 "-Wno-deprecated", 1013 "-Wno-deprecated",
1007 ] 1014 ]
(...skipping 224 matching lines...) Expand 10 before | Expand all | Expand 10 after
1232 cflags += [ "-gsplit-dwarf" ] 1239 cflags += [ "-gsplit-dwarf" ]
1233 } 1240 }
1234 } 1241 }
1235 } 1242 }
1236 1243
1237 config("no_symbols") { 1244 config("no_symbols") {
1238 if (!is_win) { 1245 if (!is_win) {
1239 cflags = [ "-g0" ] 1246 cflags = [ "-g0" ]
1240 } 1247 }
1241 } 1248 }
OLDNEW
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698