Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Side by Side Diff: components/nacl/loader/nacl_main_platform_delegate_linux.cc

Issue 1221333008: Fix unused private field errors in components/nacl/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@media_private_fields
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/nacl/loader/nacl_main_platform_delegate.h" 5 #include "components/nacl/loader/nacl_main_platform_delegate.h"
6 6
7 NaClMainPlatformDelegate::NaClMainPlatformDelegate( 7 NaClMainPlatformDelegate::NaClMainPlatformDelegate(
8 const content::MainFunctionParams& parameters) 8 const content::MainFunctionParams& parameters) {
9 : parameters_(parameters) {
10 } 9 }
11 10
12 NaClMainPlatformDelegate::~NaClMainPlatformDelegate() { 11 NaClMainPlatformDelegate::~NaClMainPlatformDelegate() {
13 } 12 }
14 13
15 void NaClMainPlatformDelegate::EnableSandbox() { 14 void NaClMainPlatformDelegate::EnableSandbox() {
16 // The setuid sandbox is started in the zygote process: zygote_main_linux.cc 15 // The setuid sandbox is started in the zygote process: zygote_main_linux.cc
17 // http://code.google.com/p/chromium/wiki/LinuxSUIDSandbox 16 // http://code.google.com/p/chromium/wiki/LinuxSUIDSandbox
18 // 17 //
19 // The seccomp sandbox is started in the renderer. 18 // The seccomp sandbox is started in the renderer.
20 // http://code.google.com/p/seccompsandbox/ 19 // http://code.google.com/p/seccompsandbox/
21 // seccomp is currently disabled for nacl. 20 // seccomp is currently disabled for nacl.
22 // http://code.google.com/p/chromium/issues/detail?id=59423 21 // http://code.google.com/p/chromium/issues/detail?id=59423
23 // See the code in chrome/renderer/renderer_main_platform_delegate_linux.cc 22 // See the code in chrome/renderer/renderer_main_platform_delegate_linux.cc
24 // for how to turn seccomp on. 23 // for how to turn seccomp on.
25 // 24 //
26 // The seccomp sandbox should not be enabled for Native Client until 25 // The seccomp sandbox should not be enabled for Native Client until
27 // all of these issues are fixed: 26 // all of these issues are fixed:
28 // http://code.google.com/p/nativeclient/issues/list?q=label:Seccomp 27 // http://code.google.com/p/nativeclient/issues/list?q=label:Seccomp
29 // At best, NaCl will not work. At worst, enabling the seccomp sandbox 28 // At best, NaCl will not work. At worst, enabling the seccomp sandbox
30 // could create a hole in the NaCl sandbox. 29 // could create a hole in the NaCl sandbox.
31 } 30 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698