Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java

Issue 1221333007: Get rid of ToolbarViewResourceFrameLayout (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Start sending ToolbarLayout itself as container Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java
index d1500bcdf19252cb253d4bf786d4241d7a50a5e5..c92def368a2ec7558044ccbb74b8c405d625c3de 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java
@@ -28,14 +28,16 @@ import org.chromium.chrome.browser.omnibox.LocationBar;
import org.chromium.chrome.browser.util.ViewUtils;
import org.chromium.chrome.browser.widget.SmoothProgressBar;
import org.chromium.chrome.browser.widget.TintedImageButton;
+import org.chromium.chrome.browser.widget.ViewResourceFrameLayout;
import org.chromium.ui.UiUtils;
+import org.chromium.ui.resources.dynamics.ViewResourceAdapter;
/**
* Layout class that contains the base shared logic for manipulating the toolbar component. For
* interaction that are not from Views inside Toolbar hierarchy all interactions should be done
* through {@link Toolbar} rather than using this class directly.
*/
-abstract class ToolbarLayout extends FrameLayout implements Toolbar {
+abstract class ToolbarLayout extends ViewResourceFrameLayout implements Toolbar {
protected static final int BACKGROUND_TRANSITION_DURATION_MS = 400;
private Invalidator mInvalidator;
@@ -68,6 +70,7 @@ abstract class ToolbarLayout extends FrameLayout implements Toolbar {
super(context, attrs);
mToolbarHeightWithoutShadow = getResources().getDimensionPixelOffset(
getToolbarHeightWithoutShadowResId());
+ setInitializedForCapture(false);
}
@Override
@@ -407,6 +410,11 @@ abstract class ToolbarLayout extends FrameLayout implements Toolbar {
return true;
}
+ @Override
+ protected ViewResourceAdapter createResourceAdapter() {
+ return new ToolbarViewResourceAdapter(this, this);
+ }
+
/**
* @param attached Whether or not the web content is attached to the view heirarchy.
*/

Powered by Google App Engine
This is Rietveld 408576698