Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Side by Side Diff: ppapi/native_client/tools/browser_tester/browsertester/browserlauncher.py

Issue 12213117: nacl_integration: disable DNS prefetching and sync. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/python 1 #!/usr/bin/python
2 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 import os.path 6 import os.path
7 import re 7 import re
8 import shutil 8 import shutil
9 import sys 9 import sys
10 import tempfile 10 import tempfile
(...skipping 253 matching lines...) Expand 10 before | Expand all | Expand 10 after
264 def NetLogName(self): 264 def NetLogName(self):
265 return os.path.join(self.profile, 'netlog.json') 265 return os.path.join(self.profile, 'netlog.json')
266 266
267 def MakeCmd(self, url, port): 267 def MakeCmd(self, url, port):
268 cmd = [self.binary, 268 cmd = [self.binary,
269 # Note that we do not use "--enable-logging" here because 269 # Note that we do not use "--enable-logging" here because
270 # it actually turns off logging to the Buildbot logs on 270 # it actually turns off logging to the Buildbot logs on
271 # Windows (see http://crbug.com/169941). 271 # Windows (see http://crbug.com/169941).
272 '--disable-web-resources', 272 '--disable-web-resources',
273 '--disable-preconnect', 273 '--disable-preconnect',
274 '--disable-sync',
Mark Seaborn 2013/02/11 22:39:41 Comment that this is speculative. Presumably no s
275 '--dns-prefetch-disable',
Mark Seaborn 2013/02/11 22:39:41 Comment that this removes a source of non-determin
274 '--no-first-run', 276 '--no-first-run',
275 '--no-default-browser-check', 277 '--no-default-browser-check',
276 '--log-level=1', 278 '--log-level=1',
277 '--safebrowsing-disable-auto-update', 279 '--safebrowsing-disable-auto-update',
278 # Suppress metrics reporting. This prevents misconfigured bots, 280 # Suppress metrics reporting. This prevents misconfigured bots,
279 # people testing at their desktop, etc from poisoning the UMA data. 281 # people testing at their desktop, etc from poisoning the UMA data.
280 '--metrics-recording-only', 282 '--metrics-recording-only',
281 # Chrome explicitly blacklists some ports as "unsafe" because 283 # Chrome explicitly blacklists some ports as "unsafe" because
282 # certain protocols use them. Chrome gives an error like this: 284 # certain protocols use them. Chrome gives an error like this:
283 # Error 312 (net::ERR_UNSAFE_PORT): Unknown error 285 # Error 312 (net::ERR_UNSAFE_PORT): Unknown error
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
327 '--trace-children=yes', 329 '--trace-children=yes',
328 '--nacl-file=%s' % (self.options.files[0],), 330 '--nacl-file=%s' % (self.options.files[0],),
329 '--ignore=../tools/valgrind/tsan/ignores.txt', 331 '--ignore=../tools/valgrind/tsan/ignores.txt',
330 '--suppressions=../tools/valgrind/tsan/suppressions.txt', 332 '--suppressions=../tools/valgrind/tsan/suppressions.txt',
331 '--log-file=%s/log.%%p' % (self.tool_log_dir,)] + cmd 333 '--log-file=%s/log.%%p' % (self.tool_log_dir,)] + cmd
332 elif self.options.tool != None: 334 elif self.options.tool != None:
333 raise LaunchFailure('Invalid tool name "%s"' % (self.options.tool,)) 335 raise LaunchFailure('Invalid tool name "%s"' % (self.options.tool,))
334 cmd.extend(self.options.browser_flags) 336 cmd.extend(self.options.browser_flags)
335 cmd.append(url) 337 cmd.append(url)
336 return cmd 338 return cmd
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698