Implemented screen notifying users about malformed HWID.

chrome/browser/chromeos/login/wizard_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/wizard_controller.h"
 
 #include <signal.h>
 #include <stdlib.h>
 #include <sys/types.h>
 
@@ skipping 10 matching lines @@
 #include "base/values.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chromeos/cros/cros_library.h"
 #include "chrome/browser/chromeos/cros/cryptohome_library.h"
 #include "chrome/browser/chromeos/customization_document.h"
 #include "chrome/browser/chromeos/login/enrollment/enterprise_enrollment_screen.h"
 #include "chrome/browser/chromeos/login/eula_screen.h"
 #include "chrome/browser/chromeos/login/existing_user_controller.h"
 #include "chrome/browser/chromeos/login/helper.h"
 #include "chrome/browser/chromeos/login/html_page_screen.h"
+#include "chrome/browser/chromeos/login/hwid_checker.h"
 #include "chrome/browser/chromeos/login/login_display_host.h"
 #include "chrome/browser/chromeos/login/login_utils.h"
 #include "chrome/browser/chromeos/login/network_screen.h"
 #include "chrome/browser/chromeos/login/oobe_display.h"
 #include "chrome/browser/chromeos/login/registration_screen.h"
 #include "chrome/browser/chromeos/login/reset_screen.h"
 #include "chrome/browser/chromeos/login/update_screen.h"
 #include "chrome/browser/chromeos/login/user_image_screen.h"
 #include "chrome/browser/chromeos/login/user_manager.h"
+#include "chrome/browser/chromeos/login/wrong_hwid_screen.h"
 #include "chrome/browser/chromeos/settings/cros_settings.h"
 #include "chrome/browser/chromeos/settings/cros_settings_names.h"
 #include "chrome/browser/prefs/pref_registry_simple.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/ui/options/options_util.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/pref_names.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/notification_service.h"
@@ skipping 57 matching lines @@
 
 const char WizardController::kNetworkScreenName[] = "network";
 const char WizardController::kLoginScreenName[] = "login";
 const char WizardController::kUpdateScreenName[] = "update";
 const char WizardController::kUserImageScreenName[] = "image";
 const char WizardController::kEulaScreenName[] = "eula";
 const char WizardController::kRegistrationScreenName[] = "register";
 const char WizardController::kHTMLPageScreenName[] = "html";
 const char WizardController::kEnterpriseEnrollmentScreenName[] = "enroll";
 const char WizardController::kResetScreenName[] = "reset";
+const char WizardController::kWrongHWIDScreenName[] = "wrong-hwid";
 
 // Passing this parameter as a "first screen" initiates full OOBE flow.
 const char WizardController::kOutOfBoxScreenName[] = "oobe";
 
 // Special test value that commands not to create any window yet.
 const char WizardController::kTestNoScreenName[] = "test:nowindow";
 
 // Initialize default controller.
 // static
 WizardController* WizardController::default_controller_ = NULL;
@@ skipping 43 matching lines @@
   bool oobe_complete = IsOobeCompleted();
   if (!oobe_complete || first_screen_name == kOutOfBoxScreenName) {
     is_out_of_box_ = true;
   }
 
   AdvanceToScreen(first_screen_name);
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_WIZARD_FIRST_SCREEN_SHOWN,
       content::NotificationService::AllSources(),
       content::NotificationService::NoDetails());
+  if (!IsMachineHWIDCorrect() && !IsDeviceRegistered() &&
+      first_screen_name.empty())
+    ShowWrongHWIDScreen();

[Nikita (slow), 2013/02/11 17:09:03]

nit: Add {}

You could also move this above and place AdvanceToScreen(first_screen_name) call
to else block.

[dzhioev (left Google), 2013/02/11 23:32:56]

I am not sure that it will be correct. We want to keep normal OOBE flow, so we
need some |previous_screen_|. The easiest way to do it is to show NetworkScreen
first.

[Nikita (slow), 2013/02/12 07:51:50]

I see, yes that makes sense to open first screen before HWID check then.

 }
 
 chromeos::NetworkScreen* WizardController::GetNetworkScreen() {
   if (!network_screen_.get())
     network_screen_.reset(new chromeos::NetworkScreen(
         this, oobe_display_->GetNetworkScreenActor()));
   return network_screen_.get();
 }
 
 chromeos::UpdateScreen* WizardController::GetUpdateScreen() {
@@ skipping 60 matching lines @@
 }
 
 chromeos::ResetScreen* WizardController::GetResetScreen() {
   if (!reset_screen_.get()) {
     reset_screen_.reset(
         new chromeos::ResetScreen(this, oobe_display_->GetResetScreenActor()));
   }
   return reset_screen_.get();
 }
 
+chromeos::WrongHWIDScreen* WizardController::GetWrongHWIDScreen() {
+  if (!wrong_hwid_screen_.get()) {
+    wrong_hwid_screen_.reset(
+        new chromeos::WrongHWIDScreen(
+            this, oobe_display_->GetWrongHWIDScreenActor()));
+  }
+  return wrong_hwid_screen_.get();
+}
+
 void WizardController::ShowNetworkScreen() {
   VLOG(1) << "Showing network screen.";
   SetStatusAreaVisible(false);
   SetCurrentScreen(GetNetworkScreen());
 }
 
 void WizardController::ShowLoginScreen() {
   if (!time_eula_accepted_.is_null()) {
     base::TimeDelta delta = base::Time::Now() - time_eula_accepted_;
     UMA_HISTOGRAM_MEDIUM_TIMES("OOBE.EULAToSignInTime", delta);
@@ skipping 74 matching lines @@
   screen->SetParameters(is_auto_enrollment, user);
   SetCurrentScreen(screen);
 }
 
 void WizardController::ShowResetScreen() {
   VLOG(1) << "Showing reset screen.";
   SetStatusAreaVisible(false);
   SetCurrentScreen(GetResetScreen());
 }
 
+void WizardController::ShowWrongHWIDScreen() {
+  VLOG(1) << "Showing wrong HWID screen.";
+  SetStatusAreaVisible(false);
+  SetCurrentScreen(GetWrongHWIDScreen());
+}
+
 void WizardController::SkipToLoginForTesting() {
   MarkEulaAccepted();
   PerformPostEulaActions();
   PerformPostUpdateActions();
   ShowLoginScreen();
 }
 
 void WizardController::SkipImageSelectionForTesting() {
   skip_user_image_selection_ = true;
 }
@@ skipping 157 matching lines @@
   ShowLoginScreen();
 }
 
 void WizardController::OnResetCanceled() {
   if (previous_screen_)
     SetCurrentScreen(previous_screen_);
   else
     ShowLoginScreen();
 }
 
+void WizardController::OnWrongHWIDWarningSkipped() {
+  if (IsOobeCompleted()) {
+    ShowLoginScreen();

[Nikita (slow), 2013/02/11 17:09:03]

nit: Drop {}

[dzhioev (left Google), 2013/02/11 23:32:56]

It seems like code is incorrect here. I'll check it tomorrow.

[Nikita (slow), 2013/02/12 07:51:50]

Do you mean that it has to use previous_screen_ here?

[dzhioev (left Google), 2013/02/12 13:57:51]

Yes, I do. I think code shoud be same as in WizardController::OnResetCanceled.

+  } else {
+    ShowNetworkScreen();
+  }
+}
+
 void WizardController::OnEnterpriseAutoEnrollmentDone() {
   VLOG(1) << "Automagic enrollment done, resuming previous signin";
   ResumeLoginScreen();
 }
 
 void WizardController::OnOOBECompleted() {
   PerformPostUpdateActions();
   ShowLoginScreen();
 }
 
@@ skipping 80 matching lines @@
     } else {
       // Just proceed to image screen.
       OnRegistrationSuccess();
     }
   } else if (screen_name == kResetScreenName) {
     ShowResetScreen();
   } else if (screen_name == kHTMLPageScreenName) {
     ShowHTMLPageScreen();
   } else if (screen_name == kEnterpriseEnrollmentScreenName) {
     ShowEnterpriseEnrollmentScreen();
+  } else if (screen_name == kWrongHWIDScreenName) {
+    ShowWrongHWIDScreen();
   } else if (screen_name != kTestNoScreenName) {
     if (is_out_of_box_) {
       ShowNetworkScreen();
     } else {
       ShowLoginScreen();
     }
   }
 }
 
 // static
@@ skipping 142 matching lines @@
       break;
     case ENTERPRISE_ENROLLMENT_COMPLETED:
       OnEnterpriseEnrollmentDone();
       break;
     case RESET_CANCELED:
       OnResetCanceled();
       break;
     case ENTERPRISE_AUTO_MAGIC_ENROLLMENT_COMPLETED:
       OnEnterpriseAutoEnrollmentDone();
       break;
+    case WRONG_HWID_WARNING_SKIPPED:
+      OnWrongHWIDWarningSkipped();
+      break;
     default:
       NOTREACHED();
   }
 }
 
 void WizardController::OnSetUserNamePassword(const std::string& username,
                                              const std::string& password) {
   username_ = username;
   password_ = password;
 }
@@ skipping 11 matching lines @@
   return zero_delay_enabled_;
 }
 
 // static
 void WizardController::SetZeroDelays() {
   kShowDelayMs = 0;
   zero_delay_enabled_ = true;
 }
 
 }  // namespace chromeos