Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(845)

Unified Diff: tests/isolate/timer_isolate_test.dart

Issue 12213092: Rework Timer interface. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/isolate/timer_cancel_test.dart ('k') | tests/isolate/timer_not_available_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/isolate/timer_isolate_test.dart
diff --git a/tests/isolate/timer_isolate_test.dart b/tests/isolate/timer_isolate_test.dart
index c9ae80c58437a3d99afe79ab05aae33c472900f6..0557d159c7d83234536ed9a2398f9d7b02eaeb91 100644
--- a/tests/isolate/timer_isolate_test.dart
+++ b/tests/isolate/timer_isolate_test.dart
@@ -8,11 +8,11 @@ import 'dart:isolate';
import 'dart:async';
import '../../pkg/unittest/lib/unittest.dart';
-const int TIMEOUT = 100;
+const Duration TIMEOUT = const Duration(milliseconds: 100);
createTimer() {
port.receive((msg, replyTo) {
- new Timer(TIMEOUT, (_) {
+ new Timer(TIMEOUT, () {
replyTo.send("timer_fired");
});
});
@@ -22,14 +22,14 @@ main() {
test("timer in isolate", () {
int startTime;
int endTime;
-
+
port.receive(expectAsync2((msg, _) {
expect("timer_fired", msg);
int endTime = (new DateTime.now()).millisecondsSinceEpoch;
expect(endTime - startTime, greaterThanOrEqualTo(TIMEOUT));
port.close();
}));
-
+
startTime = (new DateTime.now()).millisecondsSinceEpoch;
var sendPort = spawnFunction(createTimer);
sendPort.send("sendPort", port.toSendPort());
« no previous file with comments | « tests/isolate/timer_cancel_test.dart ('k') | tests/isolate/timer_not_available_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698