Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Side by Side Diff: sdk/lib/io/chunked_stream.dart

Issue 12213092: Rework Timer interface. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « sdk/lib/async/timer.dart ('k') | sdk/lib/io/file_impl.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of dart.io; 5 part of dart.io;
6 6
7 class _ChunkedInputStream implements ChunkedInputStream { 7 class _ChunkedInputStream implements ChunkedInputStream {
8 _ChunkedInputStream(InputStream this._input, int this._chunkSize) 8 _ChunkedInputStream(InputStream this._input, int this._chunkSize)
9 : _bufferList = new _BufferList() { 9 : _bufferList = new _BufferList() {
10 _input.onClosed = _onClosed; 10 _input.onClosed = _onClosed;
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 _input.onData = _onData; 85 _input.onData = _onData;
86 } else { 86 } else {
87 _input.onData = null; 87 _input.onData = null;
88 } 88 }
89 } 89 }
90 } 90 }
91 91
92 void _checkScheduleCallback() { 92 void _checkScheduleCallback() {
93 // TODO(sgjesse): Find a better way of scheduling callbacks from 93 // TODO(sgjesse): Find a better way of scheduling callbacks from
94 // the event loop. 94 // the event loop.
95 void issueDataCallback(Timer timer) { 95 void issueDataCallback() {
96 _scheduledDataCallback = null; 96 _scheduledDataCallback = null;
97 if (_clientDataHandler != null) { 97 if (_clientDataHandler != null) {
98 _clientDataHandler(); 98 _clientDataHandler();
99 _checkScheduleCallback(); 99 _checkScheduleCallback();
100 } 100 }
101 } 101 }
102 102
103 void issueCloseCallback(Timer timer) { 103 void issueCloseCallback() {
104 _scheduledCloseCallback = null; 104 _scheduledCloseCallback = null;
105 if (!_closed) { 105 if (!_closed) {
106 if (_clientCloseHandler != null) _clientCloseHandler(); 106 if (_clientCloseHandler != null) _clientCloseHandler();
107 _closed = true; 107 _closed = true;
108 } 108 }
109 } 109 }
110 110
111 // Schedule data callback if enough data in buffer. 111 // Schedule data callback if enough data in buffer.
112 if ((_bufferList.length >= _chunkSize || 112 if ((_bufferList.length >= _chunkSize ||
113 (_bufferList.length > 0 && _inputClosed)) && 113 (_bufferList.length > 0 && _inputClosed)) &&
114 _clientDataHandler != null && 114 _clientDataHandler != null &&
115 _scheduledDataCallback == null) { 115 _scheduledDataCallback == null) {
116 _scheduledDataCallback = new Timer(0, issueDataCallback); 116 _scheduledDataCallback = Timer.run(issueDataCallback);
117 } 117 }
118 118
119 // Schedule close callback if no more data and input is closed. 119 // Schedule close callback if no more data and input is closed.
120 if (_bufferList.length == 0 && 120 if (_bufferList.length == 0 &&
121 _inputClosed && 121 _inputClosed &&
122 !_closed && 122 !_closed &&
123 _scheduledCloseCallback == null) { 123 _scheduledCloseCallback == null) {
124 if (_scheduledDataCallback != null) { 124 if (_scheduledDataCallback != null) {
125 _scheduledDataCallback.cancel(); 125 _scheduledDataCallback.cancel();
126 } 126 }
127 _scheduledCloseCallback = new Timer(0, issueCloseCallback); 127 _scheduledCloseCallback = Timer.run(issueCloseCallback);
128 } 128 }
129 } 129 }
130 130
131 InputStream _input; 131 InputStream _input;
132 _BufferList _bufferList; 132 _BufferList _bufferList;
133 int _chunkSize; 133 int _chunkSize;
134 bool _inputClosed = false; // Is the underlying input stream closed? 134 bool _inputClosed = false; // Is the underlying input stream closed?
135 bool _closed = false; // Has the close handler been called?. 135 bool _closed = false; // Has the close handler been called?.
136 Timer _scheduledDataCallback; 136 Timer _scheduledDataCallback;
137 Timer _scheduledCloseCallback; 137 Timer _scheduledCloseCallback;
138 Function _clientDataHandler; 138 Function _clientDataHandler;
139 Function _clientCloseHandler; 139 Function _clientCloseHandler;
140 } 140 }
OLDNEW
« no previous file with comments | « sdk/lib/async/timer.dart ('k') | sdk/lib/io/file_impl.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698