Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Side by Side Diff: chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest_win.cc

Issue 12213091: Explicitly hardcode tab_drag_controller_interactive_uitest.cc to use the native desktop list. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge up to r181832 Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.h" 5 #include "chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/callback.h" 8 #include "base/callback.h"
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/strings/string_number_conversions.h" 10 #include "base/strings/string_number_conversions.h"
11 #include "chrome/browser/ui/browser.h" 11 #include "chrome/browser/ui/browser.h"
12 #include "chrome/browser/ui/browser_list.h" 12 #include "chrome/browser/ui/browser_list_impl.h"
13 #include "chrome/browser/ui/browser_window.h" 13 #include "chrome/browser/ui/browser_window.h"
14 #include "chrome/browser/ui/tabs/tab_strip_model.h" 14 #include "chrome/browser/ui/tabs/tab_strip_model.h"
15 #include "chrome/browser/ui/views/frame/browser_view.h" 15 #include "chrome/browser/ui/views/frame/browser_view.h"
16 #include "chrome/browser/ui/views/tabs/tab.h" 16 #include "chrome/browser/ui/views/tabs/tab.h"
17 #include "chrome/browser/ui/views/tabs/tab_drag_controller.h" 17 #include "chrome/browser/ui/views/tabs/tab_drag_controller.h"
18 #include "chrome/browser/ui/views/tabs/tab_strip.h" 18 #include "chrome/browser/ui/views/tabs/tab_strip.h"
19 #include "chrome/common/chrome_notification_types.h" 19 #include "chrome/common/chrome_notification_types.h"
20 #include "chrome/common/chrome_switches.h" 20 #include "chrome/common/chrome_switches.h"
21 #include "chrome/test/base/in_process_browser_test.h" 21 #include "chrome/test/base/in_process_browser_test.h"
22 #include "chrome/test/base/interactive_test_utils.h" 22 #include "chrome/test/base/interactive_test_utils.h"
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 ASSERT_TRUE(ui_controls::SendMouseMove( 122 ASSERT_TRUE(ui_controls::SendMouseMove(
123 tab_0_center.x(), tab_0_center.y() + tab_strip->height() + 20)); 123 tab_0_center.x(), tab_0_center.y() + tab_strip->height() + 20));
124 ASSERT_TRUE(ui_test_utils::SendMouseEventsSync( 124 ASSERT_TRUE(ui_test_utils::SendMouseEventsSync(
125 ui_controls::LEFT, ui_controls::UP)); 125 ui_controls::LEFT, ui_controls::UP));
126 126
127 // Should no longer be dragging. 127 // Should no longer be dragging.
128 ASSERT_FALSE(tab_strip->IsDragSessionActive()); 128 ASSERT_FALSE(tab_strip->IsDragSessionActive());
129 ASSERT_FALSE(TabDragController::IsActive()); 129 ASSERT_FALSE(TabDragController::IsActive());
130 130
131 // There should now be another browser. 131 // There should now be another browser.
132 ASSERT_EQ(2u, BrowserList::size()); 132 ASSERT_EQ(2u, native_browser_list->size());
133 Browser* new_browser = *(++BrowserList::begin()); 133 Browser* new_browser = native_browser_list->get(1);
134 ASSERT_TRUE(new_browser->window()->IsActive()); 134 ASSERT_TRUE(new_browser->window()->IsActive());
135 TabStrip* tab_strip2 = GetTabStripForBrowser(new_browser); 135 TabStrip* tab_strip2 = GetTabStripForBrowser(new_browser);
136 ASSERT_FALSE(tab_strip2->IsDragSessionActive()); 136 ASSERT_FALSE(tab_strip2->IsDragSessionActive());
137 137
138 EXPECT_EQ("0", IDString(new_browser->tab_strip_model())); 138 EXPECT_EQ("0", IDString(new_browser->tab_strip_model()));
139 EXPECT_EQ("1", IDString(browser()->tab_strip_model())); 139 EXPECT_EQ("1", IDString(browser()->tab_strip_model()));
140 } 140 }
141 141
142 // Deletes a tab being dragged before the user moved enough to start a drag. 142 // Deletes a tab being dragged before the user moved enough to start a drag.
143 IN_PROC_BROWSER_TEST_F(TabDragControllerTest, DeleteBeforeStartedDragging) { 143 IN_PROC_BROWSER_TEST_F(TabDragControllerTest, DeleteBeforeStartedDragging) {
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
240 // Should still be dragging. 240 // Should still be dragging.
241 ASSERT_TRUE(tab_strip->IsDragSessionActive()); 241 ASSERT_TRUE(tab_strip->IsDragSessionActive());
242 ASSERT_TRUE(TabDragController::IsActive()); 242 ASSERT_TRUE(TabDragController::IsActive());
243 243
244 // Release the mouse. 244 // Release the mouse.
245 ASSERT_TRUE(ui_test_utils::SendMouseEventsSync( 245 ASSERT_TRUE(ui_test_utils::SendMouseEventsSync(
246 ui_controls::LEFT, ui_controls::UP)); 246 ui_controls::LEFT, ui_controls::UP));
247 247
248 // Releasing the mouse should destroy the existing browser and create a new 248 // Releasing the mouse should destroy the existing browser and create a new
249 // one. 249 // one.
250 ASSERT_EQ(1u, BrowserList::size()); 250 ASSERT_EQ(1u, native_browser_list->size());
251 Browser* new_browser = *BrowserList::begin(); 251 Browser* new_browser = native_browser_list->get(0);
252 EXPECT_NE(new_browser, browser()); 252 EXPECT_NE(new_browser, browser());
253 253
254 ASSERT_FALSE(GetTabStripForBrowser(new_browser)->IsDragSessionActive()); 254 ASSERT_FALSE(GetTabStripForBrowser(new_browser)->IsDragSessionActive());
255 ASSERT_FALSE(TabDragController::IsActive()); 255 ASSERT_FALSE(TabDragController::IsActive());
256 256
257 EXPECT_EQ("0", IDString(new_browser->tab_strip_model())); 257 EXPECT_EQ("0", IDString(new_browser->tab_strip_model()));
258 } 258 }
259 259
260 // Creates two browsers, selects all tabs in first and drags into second. 260 // Creates two browsers, selects all tabs in first and drags into second.
261 IN_PROC_BROWSER_TEST_F(TabDragControllerTest, DragAllToSeparateWindow) { 261 IN_PROC_BROWSER_TEST_F(TabDragControllerTest, DragAllToSeparateWindow) {
(...skipping 16 matching lines...) Expand all
278 ASSERT_TRUE(ui_test_utils::SendMouseMoveSync(tab_0_center)); 278 ASSERT_TRUE(ui_test_utils::SendMouseMoveSync(tab_0_center));
279 ASSERT_TRUE(ui_test_utils::SendMouseEventsSync( 279 ASSERT_TRUE(ui_test_utils::SendMouseEventsSync(
280 ui_controls::LEFT, ui_controls::DOWN)); 280 ui_controls::LEFT, ui_controls::DOWN));
281 ASSERT_TRUE(ui_test_utils::SendMouseMoveSync( 281 ASSERT_TRUE(ui_test_utils::SendMouseMoveSync(
282 gfx::Point(tab_0_center.x(), 282 gfx::Point(tab_0_center.x(),
283 tab_0_center.y() + tab_strip->height() + 20))); 283 tab_0_center.y() + tab_strip->height() + 20)));
284 284
285 ASSERT_TRUE(tab_strip->IsDragSessionActive()); 285 ASSERT_TRUE(tab_strip->IsDragSessionActive());
286 ASSERT_FALSE(tab_strip2->IsDragSessionActive()); 286 ASSERT_FALSE(tab_strip2->IsDragSessionActive());
287 ASSERT_TRUE(TabDragController::IsActive()); 287 ASSERT_TRUE(TabDragController::IsActive());
288 ASSERT_EQ(2u, BrowserList::size()); 288 ASSERT_EQ(2u, native_browser_list->size());
289 289
290 // Drag to tab_strip2. 290 // Drag to tab_strip2.
291 gfx::Point target_point(tab_strip2->width() - 1, 291 gfx::Point target_point(tab_strip2->width() - 1,
292 tab_strip2->height() / 2); 292 tab_strip2->height() / 2);
293 views::View::ConvertPointToScreen(tab_strip2, &target_point); 293 views::View::ConvertPointToScreen(tab_strip2, &target_point);
294 ASSERT_TRUE(ui_controls::SendMouseMove(target_point.x(), target_point.y())); 294 ASSERT_TRUE(ui_controls::SendMouseMove(target_point.x(), target_point.y()));
295 295
296 // Should now be attached to tab_strip2. 296 // Should now be attached to tab_strip2.
297 ASSERT_TRUE(tab_strip->IsDragSessionActive()); 297 ASSERT_TRUE(tab_strip->IsDragSessionActive());
298 ASSERT_TRUE(TabDragController::IsActive()); 298 ASSERT_TRUE(TabDragController::IsActive());
(...skipping 27 matching lines...) Expand all
326 GetCenterInScreenCoordinates(tab_strip->tab_at(0))); 326 GetCenterInScreenCoordinates(tab_strip->tab_at(0)));
327 ASSERT_TRUE(ui_test_utils::SendMouseMoveSync(tab_0_center)); 327 ASSERT_TRUE(ui_test_utils::SendMouseMoveSync(tab_0_center));
328 ASSERT_TRUE(ui_test_utils::SendMouseEventsSync( 328 ASSERT_TRUE(ui_test_utils::SendMouseEventsSync(
329 ui_controls::LEFT, ui_controls::DOWN)); 329 ui_controls::LEFT, ui_controls::DOWN));
330 ASSERT_TRUE(ui_test_utils::SendMouseMoveSync( 330 ASSERT_TRUE(ui_test_utils::SendMouseMoveSync(
331 gfx::Point(tab_0_center.x(), 331 gfx::Point(tab_0_center.x(),
332 tab_0_center.y() + tab_strip->height() + 20))); 332 tab_0_center.y() + tab_strip->height() + 20)));
333 ASSERT_TRUE(tab_strip->IsDragSessionActive()); 333 ASSERT_TRUE(tab_strip->IsDragSessionActive());
334 ASSERT_FALSE(tab_strip2->IsDragSessionActive()); 334 ASSERT_FALSE(tab_strip2->IsDragSessionActive());
335 ASSERT_TRUE(TabDragController::IsActive()); 335 ASSERT_TRUE(TabDragController::IsActive());
336 ASSERT_EQ(2u, BrowserList::size()); 336 ASSERT_EQ(2u, native_browser_list->size());
337 337
338 // Drag to tab_strip2. 338 // Drag to tab_strip2.
339 gfx::Point target_point(tab_strip2->width() - 1, 339 gfx::Point target_point(tab_strip2->width() - 1,
340 tab_strip2->height() / 2); 340 tab_strip2->height() / 2);
341 views::View::ConvertPointToScreen(tab_strip2, &target_point); 341 views::View::ConvertPointToScreen(tab_strip2, &target_point);
342 ASSERT_TRUE(ui_controls::SendMouseMove(target_point.x(), target_point.y())); 342 ASSERT_TRUE(ui_controls::SendMouseMove(target_point.x(), target_point.y()));
343 343
344 ASSERT_TRUE(tab_strip->IsDragSessionActive()); 344 ASSERT_TRUE(tab_strip->IsDragSessionActive());
345 ASSERT_TRUE(TabDragController::IsActive()); 345 ASSERT_TRUE(TabDragController::IsActive());
346 ASSERT_EQ(2u, BrowserList::size()); 346 ASSERT_EQ(2u, native_browser_list->size());
347 347
348 // Cancel the drag. 348 // Cancel the drag.
349 ASSERT_TRUE(ui_test_utils::SendKeyPressSync( 349 ASSERT_TRUE(ui_test_utils::SendKeyPressSync(
350 browser2, ui::VKEY_ESCAPE, false, false, false, false)); 350 browser2, ui::VKEY_ESCAPE, false, false, false, false));
351 351
352 ASSERT_FALSE(tab_strip->IsDragSessionActive()); 352 ASSERT_FALSE(tab_strip->IsDragSessionActive());
353 ASSERT_FALSE(tab_strip2->IsDragSessionActive()); 353 ASSERT_FALSE(tab_strip2->IsDragSessionActive());
354 ASSERT_FALSE(TabDragController::IsActive()); 354 ASSERT_FALSE(TabDragController::IsActive());
355 ASSERT_EQ(2u, BrowserList::size()); 355 ASSERT_EQ(2u, native_browser_list->size());
356 EXPECT_EQ("0 1", IDString(browser()->tab_strip_model())); 356 EXPECT_EQ("0 1", IDString(browser()->tab_strip_model()));
357 EXPECT_EQ("100", IDString(browser2->tab_strip_model())); 357 EXPECT_EQ("100", IDString(browser2->tab_strip_model()));
358 } 358 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698